Repository navigation
Enforce permanent wallet compatibility and repair dependency advisory blockers - #1367
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Local pre-merge validation for exact head
The two scoped temporary overrides have maintainer owners, upstream evidence, 2026-11-06 review dates and concrete retirement checks. Public manifests/ranges and packed runtime source remain unchanged. Provenance no-downgrade, denied lifecycle scripts, audit thresholds, coverage and quality gates remain in force. David's #1366 and BRCs #351 remain held for coordination; no publication or rollout is part of this merge. |
|
Final local validation is complete; current head is The complete workspace unit command exits 0: The first repaired head failed the unchanged patch-coverage gate because the redundant Final health:check (395 tests), documentation build/link check (139 pages), and relevant formatting/governance checks pass. The full build, typecheck, unit, security-probe, signed HTTP integration, unexcluded audit and Stryker mutation results in the prior comment remain applicable to the unchanged inputs. The prior high-advisory failure, observer correction, negative controls and coverage failure are retained as separate evidence. Final exact-head runs: CI 40041245034, CodeQL 40041245128, Conformance 40041245011. Merge remains held until these and all applicable external checks pass on this exact head. David's implementation/spec reviews remain held independently. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ty-everett
left a comment
There was a problem hiding this comment.
Maintainer review complete for exact head 087692c. The permanent compatibility invariant is coherent across the canonical contributor/agent/versioning policies and PR evidence template. Reviewed the complete dependency diff: the HTTP closure remains within manifest ranges, Zod 4 stays within its upstream API range, and the unused exact-parent BiDi removal preserves the unchanged Chrome/CDP test harness and public package contracts. Owners, upstream evidence and retirement tests cover both temporary overrides.
All 50 current-head checks are terminal with no failure or pending result; selected CI, final merge gate, CodeQL, conformance, strict zero-new-Sonar and external coverage reporting pass. CodeQL analyses have zero results on merge candidate e68e971, whose parents are reviewed base de02e95 and this exact head. No unresolved review thread exists. Local unit/build/type/browser/security/HTTP/mutation evidence and retained failures are recorded above.
The operator explicitly requested this policy/advisory repair be merged after green CI. For this author-owned PR, use the repository's documented maintainer/admin facilitation; this comment records the maintainer review and does not represent a GitHub formal self-approval. No automated check, review finding or quality threshold is waived. David's implementation and spec PRs remain held independently; no package/image publication or application-service rollout is authorized by this merge.



Established application-wallet contracts must remain interoperable across independently deployed applications and wallets. This makes backward compatibility a permanent project-wide invariant: major versions, maintainer approval, migration notes and coordinated first-party upgrades cannot waive it. The root agent/contributor policies, versioning policy, PR evidence template and dedicated compatibility contract require published-client integration evidence in both old/new directions.
The policy PR was blocked by newly reported high dependency advisories. This also repairs that frozen graph while retaining the audit, lifecycle and provenance controls.
Dependency evidence
Verification
The existing governed
amount-formatmutation target passes on the repaired Stryker/Zod graph: 213 mutants, 89.20% score (189 killed, 1 timeout, 23 survived), with its normal policy and assertions unchanged. The documentation build and link checker pass for 139 pages.Self-review covers the complete final diff, public API/transport compatibility, dependency closure, private harness scope, ownership/removal conditions and security controls. No audit exclusion, threshold reduction, trust-policy bypass, disabled assertion, skipped test or deployment is introduced.
Hold merge until exact-head qualification finishes. David's implementation #1366 and companion BRCs #351 remain held for author coordination; this PR does not alter or approve those proposals. No npm/image publication or service rollout is performed.
The initial repaired head
9893f9a93passed all behavior suites but failed patch coverage because the redundant explicit CDP setting changed the standalone browser harness, which has no LCOV entry. That unnecessary edit was removed; the harness is byte-identical to main and its complete browser suite passes again. No coverage rule or threshold changed. The committed final diff passes the local patch-coverage gate with no changed production files. The original failure is retained.