Repository navigation
Repair complete release qualification and Vitest 5 execution - #1477
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
ty-everett
marked this pull request as ready for review
November 4, 2026 11:25
ty-everett
requested review from
BraydenLangley,
sirdeggen and
tonesnotes
as code owners
November 4, 2026 11:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Program and scope
PR #1093 merged as
0a43b7e45d4405a77276b6d725a910a294256ba8. Its protected release qualification failed before publication. This repairs the test evidence, supported mutation runner and bounded execution plan needed to qualify all pending main releases.a63d7671ab980fcd02a2d6d4a95abf9466992401.Impact
Excluded tests/fixtures, root development dependencies and CI/governance only. Published package bytes, public APIs, BRC-100 behavior and consumer migration remain unchanged; no cosmetic version bump.
Verification
pnpm health:check,pnpm lint,pnpm format:check,pnpm typecheck.The review record preserves failed samples and evidence limits. The parallel local lookup result with 81 timeouts is rejected; an unchanged isolated control correctly survives after competing owned work stops. Earlier failed CI, native timeout and cancelled executions remain failed evidence.
Security and dependencies
Stryker 10.1.1 includes Vitest 5 fix #6214. Its Node ≥22 requirement is satisfied by pinned Node 24.22.1; all three engine/runner peers are exactly 10.1.1. Frozen pnpm 10.33.2 installation denies lifecycle scripts. High/critical audit passes; 16 pre-existing low/moderate findings remain. Development tools do not enter public bundles. No application Vitest version changed; the separate two-package hold retains its own acceptance criteria.
Release and operations
The unchanged 156-target inventory has 606 execution units in serial batches of 256/256/94. Actual old/new-engine replay retains all old sites across 20 semantic targets plus SDK. LCH acquisition retains all 222 old-engine and 223 current-engine sites; a rejected split that omitted a parent block is recorded. No score floor, zero-uncovered/invalid rule, property minimum/seed, source inclusion, individual test deadline, mutation timeout/factor or worker count is weakened. Only measured setup/qualification outer allowances and bounded worker reuse change.
All pending public packages and official images remain unpublished. Release still requires protected qualification, pack-once OIDC publication and signed/scanned downstream images. Production remains excluded.
Completion evidence
The latest lifecycle assertions use real Node transport objects, real authentication and unchanged native protected storage/disclosure. Explicit transport metadata and disclosure-port faults are unit boundary checks, not native backend conformance claims. Every injected fault asserts that it reached the intended point. Root gates pass and all 68 selected HTTP cases pass. A first malformed authenticated BOM attempt reached client retry refusal; the corrected native handshake test proves strict parser refusal before authentication. Failed samples remain retained.
Complete hosted SDK diagnostic 41818958178 passes its 2,442-site canonical gate on a63d767: 2,173 killed, 30 timeouts, 239 survived (90.212940%), zero uncovered/invalid/unexecuted sites. All 12 archive digests verify. Exact-site/runtime comparison finds four local survivors that time out hosted; treating all four as undetected still leaves 2,199 sites detected on both platforms (90.049140%). The floor does not depend on those extra timing outcomes. This diagnostic cannot qualify publication. The complete HTTP diagnostic is passing. Full protected qualification remains required on the final merged source.
Merged as 9bdeb5f, with the exact reviewed tree. Merged-main CI 41820758846 passes 47 jobs and six expected skips; CodeQL, code generation, docs and Scorecard also pass. Protected all-pending Release 41823811793 is approved and running complete 156-target/606-execution qualification on that merged SHA. Publication still requires every automated gate; no production promotion is included.