fix(wallet-toolbox): remove unused WERR_NETWORK_CHAIN and ProcessSyncChunkResult.error

[sirdeggen]

Fixes #541 and #542.

Program and scope

• Tracker or issue: fix(wallet-toolbox): WERR_NETWORK_CHAIN is defined and deserialized but never thrown #541, fix(wallet-toolbox): ProcessSyncChunkResult.error is declared but never set or read #542
• Program gate(s) advanced: none
• Why this change is needed: @bsv/wallet-toolbox advertised two unused failure surfaces. WERR_NETWORK_CHAIN was defined and deserialized but never thrown, so readers could infer a live cross-chain sync guard that does not exist. ProcessSyncChunkResult.error was declared but never set or read, so a third-party writer could populate it and both sync loops would ignore it.
• Explicitly out of scope: adding a new live-sync chain handshake, changing BRC-38 import or ChainTracks ingest errors, and inventing a non-throwing chunk-error channel
• Exact head SHA reviewed: fbb0b5f8fb1088907decf7fde4abadd65feb424a

Impact

• No public package source or manifest changed
• Public package source or manifest changed; affected packages are listed below
• Infrastructure source, dependency, image, or deployment configuration changed
• Public API, exports, types, runtime targets, or browser/mobile behavior changed
• Security-sensitive boundary changed
• Documentation or examples changed

Affected packages/services and intended patch versions (publication occurs only
through the release workflow after approval):

• @bsv/wallet-toolbox 2.13.0 (unpublished candidate; no version bump)
• @bsv/wallet-toolbox-client 2.13.1 and @bsv/wallet-toolbox-mobile 2.13.1 share the same source and inherit the type cleanup

Verification

• Local commands and results:
  • pnpm --filter @bsv/wallet-toolbox typecheck passed
  • pnpm --filter @bsv/wallet-toolbox lint passed
  • pnpm --filter @bsv/wallet-toolbox-client typecheck passed
  • pnpm --filter @bsv/wallet-toolbox-mobile typecheck passed
  • wallet-toolbox jest (excluding man/live/bench/client/mobile): 241 suites, 2348 passed, 1 skipped
  • pnpm lint passed
  • pnpm format:check passed
  • pnpm health:check passed (208 script tests, docs/packages check, contributor policy, repository health)
• Hosted CI run: SUCCESS on exact head fbb0b5f8fb1088907decf7fde4abadd65feb424a — 35 successful, 0 failed, 6 expected scope-based skips (SDK/DID/VeriFast coverage, non-coverage packages, mutation matrix, infra). Required merge-gate, CodeQL, Sonar quality gate, Socket, codecov/patch, and conformance all passed. Run: https://github.com/bsv-blockchain/ts-stack/actions/runs/35616993704
• Conformance evidence: hosted CI / Conformance Vectors and required Conformance / ts-runner passed. BRC-40 completion still uses ProcessSyncChunkResult.done; no vector asserted error
• Coverage delta: hosted wallet-toolbox coverage shards and aggregate upload passed; codecov/patch passed
• Lint/typecheck delta: zero warnings locally; hosted CI / Build, lint, and policy passed
• Browser/mobile/packed-consumer evidence: hosted CI / Platform / wallet browser and CI / Platform / wallet mobile passed. pack:check entry-exports never listed WERR_NETWORK_CHAIN
• Performance or bundle-size delta: none expected
• I self-reviewed the complete diff for correctness, security,
  compatibility, public API, artifacts, dependencies, docs, and operations
• All applicable checks are terminal and successful on the exact head; any
  scope-based skip is expected and validated by the merge gate

Security and dependencies

• No dependency or lockfile change
• Changelog, runtime relevance, peer compatibility, transitive graph, and
  audit results were reviewed
• CodeQL/negative tests cover any changed trust boundary
• The exact-head CodeQL analysis has no new alert
• The exact-head repository quality gate reports zero new Sonar findings
  (including accepted or false-positive issue states) and zero unreviewed hotspots;
  Sonar's aggregate Quality Gate passed verdict alone is not merge evidence
• No new override, advisory dismissal, quality suppression, or skipped test
• Any temporary exception is registered with owner, evidence, review date,
  and removal condition
• Workflow permissions and lifecycle-script behavior remain least privilege

Release and operations

• No npm publication was performed from a workstation or from this PR
• Required npm patch bumps are included or intentionally deferred by the
  controlling program
• Image/SBOM/provenance/deployment/rollback impact is documented (none)
• Documentation, changelog, migration, and operational guidance are current

Decision

No existing live-sync call site throws a chain-mismatch WalletError. Portable BRC-38 import and ChainTracks ingest already throw generic Errors for different paths; rewiring those would invent new error identities. Go's ProcessSyncChunkResult has no Error field, and no TypeScript producer or consumer used error. Removal is the smallest correct fix.

Historical JSON with name WERR_NETWORK_CHAIN still deserializes as a generic WalletError.

Do not merge. Keep as draft pending maintainer review.

  

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[ty-everett]

Maintainer review: retain this as draft and redesign it compatibly. WERR_NETWORK_CHAIN is exported through the public sdk namespace and SDK subpath; removing it breaks consumer imports, instanceof checks and typed JSON round trips. ProcessSyncChunkResult.error is also a public declaration. Internal non-use and the artifact checker’s selected export list do not establish absence of external consumers. Keep/deprecate these surfaces, retain round-trip coverage, and address #541 with an explicit live-sync chain preflight and #542 with documented, tested custom-provider failure handling. Do not close those issues through an API deletion in this maintenance release. A deliberate removal would need an approved major-version migration. Current main has also advanced substantially, so final acceptance must be rerun after the compatible revision.