You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[OLYMPUS-1661]: Incorporate Filament Phone Number input plugin into the common package - #180
This PR brings the upstream Filament phone-input components into canyongbs/common, allowing Canyon GBS applications to use and maintain them without the separate plugin dependency.
Changes:
Adds phone form, table, and infolist components under Common’s namespace.
Integrates frontend assets, asset registration, and phone-processing dependencies.
Adds third-party notices and tests for configuration, format conversion, and asset safeguards.
- Deleted PhoneInputNumberType.php, PhoneEntry.php, PhoneColumn.php, PhoneInputColumn.php, and associated tests to streamline the codebase.
- Introduced new accessibility script for phone input country listbox to enhance keyboard navigation.
- Updated JavaScript files to ensure accessibility compliance.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The accessibility observer remains attached to a detached body after SPA navigation, so country lists on subsequent pages never receive tabindex; it must be reconnected or attached to a stable ancestor, and the distributed bundle regenerated.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
The added tab stop lets focus enter searchable country lists while accessibility updates remain on the unfocused search input, leaving the focused list without an accessible active option.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Fix focus and aria-activedescendant handling in searchable dropdowns
resources/js/filament/phone-input-a11y.js:40
When a searchable dropdown is rendered outside the country container, such as a fullscreen popup, this added tab stop lets keyboard users move focus from the search input into the list. Arrow keys then change the highlighted country, but aria-activedescendant is updated only on the now-unfocused search input, leaving the focused list without an accessible active option. Keep searchable lists out of the tab sequence, or implement matching listbox focus management, and regenerate the bundled asset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket(s) or GitHub Issue
Technical Description
Centralizes the Filament phone input plugin and shared configuration in Common for consistent reuse across applications.
ysfkaya/filament-phone-input(^4.2) as a Composer dependency instead of copying the plugin source.CommonServiceProvider:disableLookup().tabindexattributes.Consuming applications can remove their duplicate configuration after updating Common.
Any deployment steps required?
Are any Feature Flags and/or Data Migrations that can eventually be removed Added?
Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.