fix(jobs): load the OpenTelemetry setup in every process running app code by Tobbe · Pull Request #2973 · cedarjs/cedar

Tobbe · 2026-10-10T13:38:06Z

The OTel SDK setup file was only ever loaded by the dev API server watcher, and via --require, which cannot load an ESM file that uses top-level await.

A shared getOTelImportArgs() helper in @cedarjs/project-config resolves the built api/dist/opentelemetry.js and returns a --import=<path> entry. It is now used by:

the dev watcher (api-server-watch) — replacing the inline --require logic
the production API server with a server file (cedarjs-server api, cedar serve api)
the job workers (cedar jobs work|start forks)
the default in-process API server, which await import()s the setup file before Fastify, Prisma and the app's own modules load

The setup command now prints the flag to use when running under your own process manager.

Opened from a branch in this repo so the full CI suite runs. Original PR by @niukanen1: #2887

…code The OTel SDK setup file was only loaded by the dev API server watcher, and via --require, which cannot load an ESM file using top-level await. A shared getOTelImportArgs() helper now preloads api/dist/opentelemetry.js with --import in the production API server (both the server-file path and the default server), the job workers, and the dev watcher. The default in-process server imports the setup file before Fastify and Prisma load. The setup command prints the flag to use under your own process manager.

…s serving The setup path is now returned as a file URL so Node resolves it as an ESM specifier on Windows too. The default API server and the both-sides in-process server import Fastify and the server factory after the setup file, so the Fastify instrumentation can still patch them. The bin entry loads the api handlers lazily for the same reason. cedar serve --ud imports the setup before the built Fetchable, cedar serve with a custom server file preloads it on the node process for both sides, and the setup command notice mentions the covered modes.

The lazy-handler change dropped the webHandler import, so cedarjs-server web crashed with a ReferenceError before parsing options.

netlify · 2026-10-10T13:38:12Z

✅ Deploy Preview for cedarjs canceled.

Name	Link
🔨 Latest commit	`99c31e5`
🔍 Latest deploy log	https://app.netlify.com/projects/cedarjs/deploys/6aca3fc231a9180009154e3f

coderabbitai · 2026-10-10T13:39:23Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: e8488a8e-7017-4ef6-83b9-d3193da73dfd

📥 Commits

Reviewing files that changed from the base of the PR and between f21b071 and 99c31e5.

📒 Files selected for processing (13)

packages/api-server-watch/src/serverManager.ts
packages/api-server/src/apiCLIConfigHandler.ts
packages/api-server/src/bin.ts
packages/api-server/src/bothCLIConfigHandler.ts
packages/api-server/src/serverFile.ts
packages/cli/src/commands/experimental/setupOpentelemetryHandler.ts
packages/cli/src/commands/serve.ts
packages/cli/src/commands/serveApiHandler.ts
packages/cli/src/commands/serveBothHandler.ts
packages/jobs/src/bins/cedar-jobs.ts
packages/project-config/src/__tests__/otel.test.ts
packages/project-config/src/index.ts
packages/project-config/src/otel.ts

 __________________________________________________
< Deploying the charm offensive against your bugs. >
 --------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

greptile-apps · 2026-10-10T13:43:15Z

Confidence Score: 4/5

[High impact] Refactors OpenTelemetry preload across multiple process launchers.

Fix the combined-server command's quoting before merging; valid project paths can now prevent API startup.

Findings

Project paths break server startup ▶
Unified dev notice promises traces ▶
Tests change shared fixture files ▶

Summary

The PR adds a shared OpenTelemetry preload helper and uses it before API modules and job workers load.

The dev API watcher loads the telemetry setup with Node’s ESM import flag.
API servers load the telemetry setup before app modules.
Job workers preload telemetry, and the setup command explains manual startup.

_{Reviews (1) · Last reviewed commit: "fix(api-server): restore the web command..." · Reviewed by Greptile}

greptile-apps · 2026-10-10T13:43:18Z

        {
          name: 'api',
-          command: `${formatRunBinCommand('node', [path.join('dist', 'server.js'), '--apiPort', String(argv.apiPort), '--apiHost', argv.apiHost, '--apiRootPath', apiRootPath])}`,
+          command: `${formatRunBinCommand('node', [...getOTelImportArgs(), path.join('dist', 'server.js'), '--apiPort', String(argv.apiPort), '--apiHost', argv.apiHost, '--apiRootPath', apiRootPath])}`,


Project paths break server startup

If the project directory contains shell characters, such as /srv/cedar&demo, cedar serve with OpenTelemetry enabled and a custom server now fails to start the API. The new absolute file URL goes into an unquoted shell command. The & remains in the URL, so the shell splits the command instead of passing the complete --import argument to Node.

Quote the preload argument for the shell, or launch Node with an argument array.

greptile-apps · 2026-10-10T13:43:18Z

+      title: 'Notice: running under your own process manager...',
+      task: (_ctx: unknown, task: { output: string }) => {
+        task.output = [
+          'The setup file is loaded automatically by `cedar dev` (including `--ud`), `cedar serve api`, `cedar serve`, `cedarjs-server api` and the job workers.',


Unified dev notice promises traces

The new notice says cedar dev --ud loads the setup automatically, but that command starts cedar-unified-dev, which does not import the setup. Its OpenTelemetry code only adds tracing calls to API source files; it does not register a provider or exporter. Users following this guidance can expect traces that never get exported.

Remove the --ud claim until that startup path loads the setup.

Suggested change

'The setup file is loaded automatically by `cedar dev` (including `--ud`), `cedar serve api`, `cedar serve`, `cedarjs-server api` and the job workers.',

'The setup file is loaded automatically by `cedar dev` without `--ud`, `cedar serve api`, `cedar serve`, `cedarjs-server api` and the job workers.',

greptile-apps · 2026-10-10T13:43:18Z

+    const configPath = path.join(FIXTURE_BASEDIR, 'redwood.toml')
+    const originalConfig = fs.readFileSync(configPath, 'utf-8')
+    try {
+      fs.writeFileSync(
+        configPath,
+        originalConfig.concat(
+          '\n[experimental.opentelemetry]\n\tenabled = true\n\twrapApi = true\n',
+        ),
+      )


Tests change shared fixture files

These tests rewrite the shared empty-project/redwood.toml and remove the entire api/dist directory during cleanup. Other test files read this fixture, and the test configuration allows parallel files. Readers can therefore see the configuration while it is being rewritten, and future tests that add build files can have those files deleted.

Use a private temporary project, or mock configuration and file checks.

niukanen1 added 3 commits September 29, 2026 16:02

fix(api-server): restore the web command handler in the bin entry

99c31e5

The lazy-handler change dropped the webHandler import, so cedarjs-server web crashed with a ReferenceError before parsing options.

github-actions Bot added this to the next-release-patch milestone Oct 10, 2026

Tobbe closed this Oct 10, 2026

Tobbe deleted the fix/2861-otel-load-in-all-processes branch October 10, 2026 13:39

greptile-apps Bot reviewed Oct 10, 2026

View reviewed changes

Navigation Menu

Repository navigation

fix(jobs): load the OpenTelemetry setup in every process running app code - #2973

fix(jobs): load the OpenTelemetry setup in every process running app code#2973
Tobbe wants to merge 3 commits into
mainfrom
fix/2861-otel-load-in-all-processes

Tobbe commented Oct 10, 2026

Uh oh!

netlify Bot commented Oct 10, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 10, 2026

Uh oh!

greptile-apps Bot commented Oct 10, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot Oct 10, 2026

Uh oh!

greptile-apps Bot Oct 10, 2026

Uh oh!

greptile-apps Bot Oct 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	'The setup file is loaded automatically by `cedar dev` (including `--ud`), `cedar serve api`, `cedar serve`, `cedarjs-server api` and the job workers.',
	'The setup file is loaded automatically by `cedar dev` without `--ud`, `cedar serve api`, `cedar serve`, `cedarjs-server api` and the job workers.',

Conversation

Tobbe commented Oct 10, 2026

Uh oh!

netlify Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cedarjs canceled.

Uh oh!

coderabbitai Bot commented Oct 10, 2026

Uh oh!

greptile-apps Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 4/5

Findings

Summary

Uh oh!

greptile-apps Bot Oct 10, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 10, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify Bot commented Oct 10, 2026 •

edited

Loading

greptile-apps Bot commented Oct 10, 2026 •

edited

Loading