CFE-4074: Added a new input-type: file - #330
Conversation
|
Thank you for submitting a pull request! Maybe @craigcomstock can review this? |
fc823ae to
af9f529
Compare
af9f529 to
379a416
Compare
larsewi
left a comment
larsewi
left a comment
There was a problem hiding this comment.
Ticket number looks wrong https://northerntech.atlassian.net/browse/ENT-4074
379a416 to
62aad2a
Compare
Ticket: CFE-4074 Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
62aad2a to
4ceb73a
Compare
SimonThalvorsen
changed the title
larsewi
left a comment
larsewi
left a comment
There was a problem hiding this comment.
I would like @nickanderson or @olehermanse to review this before we merge
| if os.path.commonpath([abs_path, module_root]) != module_root: | ||
| continue |
There was a problem hiding this comment.
A comment here would be nice
|
|
||
|
|
||
| def _perform_input_step(args, name, destination, prefix): | ||
| def _path_if_already_shipped(path, build_modules, destination): |
There was a problem hiding this comment.
So this function both tests if the file is already shipped and computes the if not? It feels a bit messy, but I don't know how to make it better.
| "variables": { | ||
| "run_script_module:main.scripts": { | ||
| "value": [ | ||
| "$(sys.inputdir)/services/cfbs/scripts/script1.sh", |
There was a problem hiding this comment.
So the file input paths end up in the augments? Should you be able to add files without having them modifying augments? E.g., by omitting variable, namespace, bundle?
| @@ -0,0 +1,48 @@ | |||
| set -e | |||
There was a problem hiding this comment.
Please add a test here testing no extension constraints.
3 participants
Ticket: CFE-4074