CFE-942: Fixed usemodule() reporting success when the module exited non-zero (3.24) - #6286
Open
nickanderson wants to merge 1 commit into
Open
CFE-942: Fixed usemodule() reporting success when the module exited non-zero (3.24)#6286nickanderson wants to merge 1 commit into
nickanderson wants to merge 1 commit into
Conversation
usemodule() ignored the module's exit status and defined its class either way. It returns false now when the module ran and failed, and only fails as a function when the module could not be run or read at all. The distinction matters: a failed function call leaves the class undefined rather than false, so "not => usemodule(...)" would not have become true either. The test could not pass or fail whatever the code did. It looked for the modules one directory too high, its Pass guard asked for a class and its own negation, and the module it runs exits 1 on purpose which failed the whole test bundle. With those corrected it fails on the old code and passes on the new. Ticket: CFE-942 Changelog: Title Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> (cherry picked from commit a5b28ff)
larsewi
approved these changes
Aug 13, 2026
Member
Author
|
@cf-bottom jenkins please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14488/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14488/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #6273. usemodule() now returns false when the module ran and exited
non-zero, and only fails as a function when the module could not be run at all.
Ticket: CFE-942