Repository navigation
Conversation
Tests for the follow-ups of the private-reply reaction review: a recovered receive's receipt lookup and an Enhance query a recovery reply creates wait for the next block, a same-block catch-up asks about the first pass's addresses, a stale-routing retry asks the same rows whatever a reply cleared, no service retry stays due once recovery is off, and a given-up receipt neither spins nor promises an update. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rent PIR session Pins every wallet-libraries dependency to the head of draft PR #213, stacked on draft PR #212: lookups a private reply queues, and window growth it causes, wait for the next chain tip. Each wallet's handles share one TransparentPirSession, as they share the Enhance session, so the handle that queues work and the one that lists it agree. zcash_voting still pins an older wallet-libraries revision; a git patch moves its zakura-wallet-lib to the same revision so voting and the wallet share one copy of each crate. Tests that grew a window several times at one target start each growth from a fresh session. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Record the Enhance queries and status lookups a transparent recovery run creates, as each drain point does, so a sync resumed at the same block neither asks nor counts them. - After stale routing (409/410), retry the batch's rows that were not asked, not a fresh read of the wallet, so a reply that resolved another request cannot change the retry. - Drop expired service waits when recovery is off or stopped by a policy change, so the tip poll does not start a sync every 10 s. - Show a given-up receipt lookup without the loading icon or the promise of an update, and fix a stale comment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups to the review of #999, where a private reply could still change what the wallet asks at the same block. Stacked on #999 and pinned to two draft wallet-libraries PRs: zakura-core/wallet-libraries#212 (receipt lookups a reply queues wait for the next chain tip) and zakura-core/wallet-libraries#213 (window growth is watched from the next recovery target), which is stacked on #212.
Breaking changes
None for users. One build change:
zcash_votingstill pins an older wallet-libraries revision through git. To keep a single copy of the wallet crates, a git patch moves itszakura-wallet-libto the same revision. Cargo rejects a patch that points at the same URL, so every wallet-libraries dependency now names the repository with agit@user (https://git@github.com/...). GitHub serves that anonymously. Both the patch and the user part can go oncezcash_votingmoves to the same revision. When #212 and #213 merge, this repins to wallet-libraries main.Validation
Tests came first in their own commit, and each failed on #999's head at its target assertion:
Vizor has no PR test CI, so these are local results at this branch's head:
🤖 Generated with Claude Code