Repository navigation
refactor!: remove configured_addr config - #8711
Conversation
2deae58 to
6ad0f04
Compare
46acbc7 to
494be7f
Compare
6ad0f04 to
afca961
Compare
494be7f to
9b3f6a6
Compare
4fc4ff3 to
4750068
Compare
7c0aec6 to
233c2cb
Compare
ae10a5e to
240121c
Compare
240121c to
4acf71d
Compare
This comment was marked as low quality.
This comment was marked as low quality.
|
@pbuzdin please create a separate account for your bot and don't let it post any comments in any chatmail or deltachat organization repositories. There are some community standards at https://delta.chat/en/community-standards, but even if they were not written down, it should be obvious that it is not great to run a bot that posts comments here pretending to be a human and then note that "a first-class preferred-transport concept has been requested there (comment 6090501441)" in pbuzdin/velta#114 (comment) |
|
That wasnt a bot comment. I wrote it myself because I'm having trouble using Deltachat in my region without manually selecting a relay for sending. |
|
our idea for situation "one relay cannot send" is to improve sending failover. or, in the future, replacing that relay automatically. adding more options, that most ppl would not understand, is often not a solution from our view. a configured_addr or used_for_sending were always meant as temporary things since we introduced multi relay. not having tons of options is also easier for us to debug and to get the model. nerds detecting smth is wrong with a relay, by some log or so, can remove it. as a general rule of thumb, we avoid options and beforehand questions whereever we can. btw: the screenshots of velta look great! |
e073767 to
f25c3ac
Compare
e51fc0e to
a101a2f
Compare
2b5482f to
4d19d35
Compare
8a5f445 to
0e81c0d
Compare
a4925a2 to
33c2c81
Compare
configured_addr config
0e81c0d to
6a3216e
Compare
33c2c81 to
de8c2fd
Compare
0aa0eb4 to
21d8713
Compare
| [transport1, transport2] = ac1_transports | ||
| ac1_clone.wait_for_event(EventType.TRANSPORTS_MODIFIED) | ||
| assert len(ac1_clone.list_transports()) == 2 | ||
| assert ac1_clone.get_config("configured_addr") == transport1["addr"] |
There was a problem hiding this comment.
The test name and comments need to be updated, because they say "new_as_primary" and "a transport promoted on one device", which is not true anymore
|
|
||
| /// Update deprecated `configured_addr` config so it points to the first transport. | ||
| /// | ||
| /// `configured_addr` is not used anymore, but old core fails when importing a backup without it, |
There was a problem hiding this comment.
Would be nice to add the date so we can remove it in the future
| /// `configured_addr` is not used anymore, but old core fails when importing a backup without it, | |
| /// `configured_addr` is not used anymore, | |
| /// but old core (2026-11) fails when importing a backup without it, |
b261968 to
8b846c0
Compare
configured_addr was already not used by real SMTP code. Rust tests which emulate sending with TestContext.pop_sent_msg() now have a way to set the "sending" address manually in memory.
8b846c0 to
42cb9d9
Compare
configured_addr was already not used by real SMTP code.
Rust tests which emulate sending with TestContext.pop_sent_msg()
now have a way to set the "sending" address manually in memory.
Closes #8572