Skip to content

refactor!: remove configured_addr config - #8711

Merged
link2xt merged 1 commit into
mainfrom
link2xt/remove-configured-addr
Oct 27, 2026
Merged

link2xt merged 1 commit into
mainfrom
link2xt/remove-configured-addr

Conversation

@link2xt

@link2xt link2xt commented Sep 17, 2026 •

Copy link
Copy Markdown
Collaborator

configured_addr was already not used by real SMTP code.
Rust tests which emulate sending with TestContext.pop_sent_msg()
now have a way to set the "sending" address manually in memory.

Closes #8572

@link2xt
link2xt force-pushed the link2xt/smtp-failover branch from 2deae58 to 6ad0f04 Compare September 17, 2026 19:00
@link2xt
link2xt force-pushed the link2xt/remove-configured-addr branch from 46acbc7 to 494be7f Compare September 17, 2026 19:00
@link2xt
link2xt force-pushed the link2xt/smtp-failover branch from 6ad0f04 to afca961 Compare September 18, 2026 08:10
@link2xt
link2xt force-pushed the link2xt/remove-configured-addr branch from 494be7f to 9b3f6a6 Compare September 18, 2026 08:10
@link2xt
link2xt force-pushed the link2xt/smtp-failover branch 2 times, most recently from 4fc4ff3 to 4750068 Compare September 18, 2026 16:53
Base automatically changed from link2xt/smtp-failover to main September 18, 2026 17:10
@link2xt
link2xt force-pushed the link2xt/remove-configured-addr branch 2 times, most recently from 7c0aec6 to 233c2cb Compare September 19, 2026 20:19
@link2xt
link2xt force-pushed the link2xt/remove-configured-addr branch 8 times, most recently from ae10a5e to 240121c Compare October 9, 2026 20:28
@link2xt link2xt changed the title WIP: remove maybe_update_sending_transport (and remaining usage of ConfiguredAddr) WIP: refactor: remove ConfiguredAddr Oct 9, 2026
@link2xt link2xt changed the title WIP: refactor: remove ConfiguredAddr refactor: remove ConfiguredAddr Oct 9, 2026
@link2xt
link2xt force-pushed the link2xt/remove-configured-addr branch from 240121c to 4acf71d Compare October 9, 2026 20:34
@pbuzdin

This comment was marked as low quality.

@link2xt

link2xt commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator Author

@pbuzdin please create a separate account for your bot and don't let it post any comments in any chatmail or deltachat organization repositories. There are some community standards at https://delta.chat/en/community-standards, but even if they were not written down, it should be obvious that it is not great to run a bot that posts comments here pretending to be a human and then note that "a first-class preferred-transport concept has been requested there (comment 6090501441)" in pbuzdin/velta#114 (comment)

@pbuzdin

pbuzdin commented Oct 10, 2026

Copy link
Copy Markdown

That wasnt a bot comment. I wrote it myself because I'm having trouble using Deltachat in my region without manually selecting a relay for sending.

@r10s

r10s commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

our idea for situation "one relay cannot send" is to improve sending failover. or, in the future, replacing that relay automatically.

adding more options, that most ppl would not understand, is often not a solution from our view. a configured_addr or used_for_sending were always meant as temporary things since we introduced multi relay. not having tons of options is also easier for us to debug and to get the model.

nerds detecting smth is wrong with a relay, by some log or so, can remove it.

as a general rule of thumb, we avoid options and beforehand questions whereever we can.

btw: the screenshots of velta look great!

@link2xt
link2xt force-pushed the link2xt/remove-configured-addr branch 2 times, most recently from e073767 to f25c3ac Compare October 10, 2026 19:18
@link2xt
link2xt changed the base branch from main to link2xt/pseudo-transport-start-stop-io October 19, 2026 14:22
@link2xt
link2xt force-pushed the link2xt/remove-configured-addr branch from e51fc0e to a101a2f Compare October 19, 2026 14:28
@link2xt
link2xt marked this pull request as draft October 19, 2026 14:36
@link2xt
link2xt force-pushed the link2xt/remove-configured-addr branch 3 times, most recently from 2b5482f to 4d19d35 Compare October 19, 2026 14:53
@link2xt
link2xt force-pushed the link2xt/pseudo-transport-start-stop-io branch 3 times, most recently from 8a5f445 to 0e81c0d Compare October 20, 2026 04:40
@link2xt
link2xt force-pushed the link2xt/remove-configured-addr branch 2 times, most recently from a4925a2 to 33c2c81 Compare October 20, 2026 05:54
@link2xt link2xt changed the title refactor: remove ConfiguredAddr refactor!: remove configured_addr config Oct 20, 2026
@link2xt
link2xt requested a review from Hocuri October 20, 2026 06:27
@link2xt
link2xt marked this pull request as ready for review October 20, 2026 06:27
@link2xt
link2xt force-pushed the link2xt/pseudo-transport-start-stop-io branch from 0e81c0d to 6a3216e Compare October 20, 2026 10:05
@link2xt
link2xt force-pushed the link2xt/remove-configured-addr branch from 33c2c81 to de8c2fd Compare October 20, 2026 10:12
Base automatically changed from link2xt/pseudo-transport-start-stop-io to main October 20, 2026 10:17
@link2xt
link2xt force-pushed the link2xt/remove-configured-addr branch 6 times, most recently from 0aa0eb4 to 21d8713 Compare October 26, 2026 15:17
[transport1, transport2] = ac1_transports
ac1_clone.wait_for_event(EventType.TRANSPORTS_MODIFIED)
assert len(ac1_clone.list_transports()) == 2
assert ac1_clone.get_config("configured_addr") == transport1["addr"]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test name and comments need to be updated, because they say "new_as_primary" and "a transport promoted on one device", which is not true anymore

Comment thread src/transport.rs Outdated

/// Update deprecated `configured_addr` config so it points to the first transport.
///
/// `configured_addr` is not used anymore, but old core fails when importing a backup without it,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add the date so we can remove it in the future

Suggested change
/// `configured_addr` is not used anymore, but old core fails when importing a backup without it,
/// `configured_addr` is not used anymore,
/// but old core (2026-11) fails when importing a backup without it,

@link2xt
link2xt force-pushed the link2xt/remove-configured-addr branch 2 times, most recently from b261968 to 8b846c0 Compare October 27, 2026 10:50
configured_addr was already not used by real SMTP code.
Rust tests which emulate sending with TestContext.pop_sent_msg()
now have a way to set the "sending" address manually in memory.
@link2xt
link2xt force-pushed the link2xt/remove-configured-addr branch from 8b846c0 to 42cb9d9 Compare October 27, 2026 10:53
@link2xt
link2xt merged commit 9e346ac into main Oct 27, 2026
30 checks passed
@link2xt
link2xt deleted the link2xt/remove-configured-addr branch October 27, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dissolve "primary" relay notion (configured_addr)

4 participants