Repository navigation
feat!: remove debug logging webxdc integration - #8872
Merged
Merged
Conversation
link2xt
marked this pull request as ready for review
October 29, 2026 15:35
Hocuri
approved these changes
Nov 1, 2026
| } | ||
|
|
||
| // Maybe set logging xdc and add gossip topics for webxdcs. | ||
| for (part, msg_id) in mime_parser.parts.iter().zip(&created_db_entries) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| for (part, msg_id) in mime_parser.parts.iter().zip(&created_db_entries) { | |
| // Add gossip topics for webxdcs. | |
| for (part, msg_id) in mime_parser.parts.iter().zip(&created_db_entries) { |
r10s
approved these changes
Nov 1, 2026
"Debug logging" is a hidden experimental feature that sends all events as webxdc updates to a webxdc named "debug_logging.xdc" and posted to "Saved messages". AFAIK it was not used by anyone recently, but the main reason to remove it now is that the way it is implemented it only works if events are emitted through the `Context`. I want to pass `Events` (sender side of the event channel) to some tasks so they don't hold a reference to the `Context` and don't prevent the database from closing, but if I do it now then events logged from these tasks will not be passed to debug logging XDC.
link2xt
force-pushed
the
link2xt/remove-debug-logging-xdc
branch
from
November 3, 2026 14:08
7eda1d4 to
c789157
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Debug logging" is a hidden experimental feature that sends all events as webxdc updates to a webxdc named "debug_logging.xdc" and posted to "Saved messages".
AFAIK it was not used by anyone recently, but the main reason to remove it now is that the way it is implemented it only works if events are emitted through the
Context. I want to passEvents(sender side of the event channel) to some tasks so they don't hold a reference to theContext(in #8867; EDIT: this is not actually possible, still needContextto store DNS cache and write toconnection_history) and don't prevent the database from closing, but if I do it now then events logged from these tasks will not be passed to debug logging XDC.