Skip to content

fix: simplify determination of webxdc apps - #8910

Open
hpk42 wants to merge 1 commit into
mainfrom
hpk/webxdc-mime-type
Open

hpk42 wants to merge 1 commit into
mainfrom
hpk/webxdc-mime-type

Conversation

@hpk42

@hpk42 hpk42 commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

This fixes a regression reported in Android deltachat/deltachat-android#4826

Android sometimes attaches apps with application/octet-stream mime type, and receivers using core 2.67/68 did not show them as mini-apps. Detecting incoming apps by file name extension alone lets apps from older Android versions arrive correctly, and always labelling outgoing apps application/webxdc+zip lets receivers still using core 2.67/68 show them too. Fix mostly follows the suggestions from hocuri and r10s in #8820 (comment)

This fixes a regression from #8820.
Android sometimes attaches apps with application/octet-stream mime type,
and receivers using core 2.67/68 did not show them as mini-apps.
Detecting incoming apps by file name extension alone
lets apps from older Android versions arrive correctly,
and always labelling outgoing apps application/webxdc+zip
lets receivers still using core 2.67/68 show them too.
@link2xt

link2xt commented Nov 8, 2026

Copy link
Copy Markdown
Collaborator

We should probably start ignoring filemime argument passed by UIs to dc_msg_set_file_and_deduplicate and deprecate it. DC Android uses getMimeTypeFromExtension internally, so it is worse than our own guess from the extension that we can at least keep consistent across UIs and we know about .xdc extension.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants