Repository navigation
Conversation
ccclxxiii
temporarily deployed
to
staging.chatmail.at/doc/relay/
June 25, 2026 13:19 — with
GitHub Actions
Inactive
ccclxxiii
requested review from
Simon-Laux,
adbenitez,
feld,
j-g00da,
j4n,
link2xt and
missytake
June 25, 2026 13:29
j-g00da
reviewed
Jun 25, 2026
Comment on lines
+7
to
+136
| CHATMAIL_UNITS = [ | ||
| "doveauth.service", | ||
| "lastlogin.service", | ||
| "chatmail-metadata.service", | ||
| "chatmail-expire.service", | ||
| "chatmail-expire.timer", | ||
| "chatmail-fsreport.service", | ||
| "chatmail-fsreport.timer", | ||
| "filtermail.service", | ||
| "filtermail-incoming.service", | ||
| "filtermail-transport.service", | ||
| "turnserver.service", | ||
| "iroh-relay.service", | ||
| "mtail.service", | ||
| "acmetool-redirector.service", | ||
| "acmetool-reconcile.service", | ||
| "acmetool-reconcile.timer", | ||
| "tls-cert-reload.path", | ||
| "tls-cert-reload.service", | ||
| ] | ||
|
|
||
| LEGACY_UNITS = [ | ||
| "doveauth-dictproxy.service", | ||
| "echobot.service", | ||
| "mta-sts-daemon.service", | ||
| ] | ||
|
|
||
| PACKAGE_UNITS = [ | ||
| "dovecot.service", | ||
| "postfix.service", | ||
| "nginx.service", | ||
| "opendkim.service", | ||
| "unbound.service", | ||
| "fcgiwrap.service", | ||
| ] | ||
|
|
||
| PACKAGE_NAMES = [ | ||
| "acmetool", | ||
| "dovecot-core", | ||
| "dovecot-imapd", | ||
| "dovecot-lmtpd", | ||
| "postfix", | ||
| "opendkim", | ||
| "opendkim-tools", | ||
| "nginx", | ||
| "nginx-common", | ||
| "libnginx-mod-stream", | ||
| "fcgiwrap", | ||
| "unbound", | ||
| "unbound-anchor", | ||
| "dnsutils", | ||
| "python3-virtualenv", | ||
| "gcc", | ||
| "python3-dev", | ||
| "curl", | ||
| "rsync", | ||
| ] | ||
|
|
||
| RELAY_FILES = [ | ||
| "/etc/apt/apt.conf.d/00InstallRecommends", | ||
| "/etc/apt/keyrings/obs-home-deltachat.gpg", | ||
| "/etc/apt/preferences.d/pin-dovecot", | ||
| "/etc/chatmail-nocreate", | ||
| "/etc/chatmail-version", | ||
| "/etc/cron.d/acmetool", | ||
| "/etc/cron.d/chatmail-metrics", | ||
| "/etc/cron.d/expunge", | ||
| "/etc/dovecot/auth.conf", | ||
| "/etc/dovecot/dovecot.conf", | ||
| "/etc/dovecot/push_notification.lua", | ||
| "/etc/iroh-relay.toml", | ||
| "/etc/mailname", | ||
| "/etc/mta-sts-daemon.yml", | ||
| "/etc/mtail/delivered_mail.mtail", | ||
| "/etc/nginx/nginx.conf", | ||
| "/etc/opendkim.conf", | ||
| "/etc/postfix/lmtp_header_cleanup", | ||
| "/etc/postfix/login_map", | ||
| "/etc/postfix/main.cf", | ||
| "/etc/postfix/master.cf", | ||
| "/etc/postfix/smtp_tls_policy_map", | ||
| "/etc/postfix/smtp_tls_policy_map.db", | ||
| "/etc/postfix/submission_header_cleanup", | ||
| "/etc/systemd/journald.conf", | ||
| "/etc/systemd/system/mta-sts-daemon.service", | ||
| "/etc/systemd/system/dovecot.service.d/10_restart.conf", | ||
| "/etc/systemd/system/opendkim.service.d/10-prevent-memory-leak.conf", | ||
| "/etc/systemd/system/postfix@.service.d/10_restart.conf", | ||
| "/etc/unbound/unbound.conf.d/chatmail.conf", | ||
| "/usr/lib/cgi-bin/newemail.py", | ||
| "/usr/local/bin/chatmail-turn", | ||
| "/usr/local/bin/filtermail", | ||
| "/usr/local/bin/iroh-relay", | ||
| "/usr/local/bin/mtail", | ||
| "/usr/sbin/policy-rc.d", | ||
| "/var/www/html/metrics", | ||
| ] | ||
|
|
||
| PACKAGE_CONFIG_DIRS = [ | ||
| "/etc/dkimkeys", | ||
| "/etc/dovecot", | ||
| "/etc/nginx", | ||
| "/etc/opendkim", | ||
| "/etc/postfix", | ||
| "/etc/unbound", | ||
| ] | ||
|
|
||
| RELAY_DIRS = [ | ||
| "/etc/mtail", | ||
| "/root/from-cmdeploy", | ||
| "/usr/local/lib/chatmaild", | ||
| "/usr/local/lib/postfix-mta-sts-resolver", | ||
| "/var/lib/dovecot", | ||
| "/var/lib/nginx", | ||
| "/var/lib/postfix", | ||
| "/var/lib/unbound", | ||
| "/var/log/nginx", | ||
| "/var/spool/postfix", | ||
| "/var/www/html", | ||
| ] | ||
|
|
||
| EMPTY_SYSTEMD_DIRS = [ | ||
| "/etc/systemd/system/dovecot.service.d", | ||
| "/etc/systemd/system/opendkim.service.d", | ||
| "/etc/systemd/system/postfix@.service.d", | ||
| ] | ||
|
|
||
| RELAY_USERS = ["vmail", "iroh", "opendkim"] | ||
| RELAY_GROUPS = ["vmail", "iroh", "opendkim"] | ||
|
|
Collaborator
There was a problem hiding this comment.
Maybe we should keep paths/file names/package names in dicts in something like constants.py, then reference them everywhere instead of hardcoding strings all over the place. This way we can be sure that what is deployed matches what is removed (this can very easily diverge and be missed in a review).
Contributor
Author
There was a problem hiding this comment.
@j-g00da that's a good call, thank you. let's see if anyone else has input. but a const would make sense so you change it in one place. appreciate the feedback.
Contributor
Author
There was a problem hiding this comment.
@j-g00da made another pass in d7a16d2be1d99fa4569785a2780f4a4e8ae074c1
Contributor
Author
|
closing re: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr overview:
cmdeployremove so operators can tear down relay from server before redeploying or decommissioning it.--dry-run,--yes, and--keep-packages.accounturigotcha when redeploying after ACME state is removed.darkrun.devlive