Repository navigation
fix(policy): single-quote the policy name in the exported client.rb - #259
Merged
Merged
Conversation
policy export wrote `policy_name %q`, and Go's %q is a Ruby double-quoted
string, which interpolates #{...}. The name comes from the lock file, so a
lock named `#{system("...")}` ran code when cinc-client -z loaded the
export. Quote it the way bootstrap already quotes its client.rb values,
now shared as cli/rubylit.
Signed-off-by: Tim Smith <tsmith84@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cinc policy exportwrote the generatedclient.rbwithpolicy_name %q. Go's%qproduces a Ruby double-quoted string, which interpolates#{...}. The policy name comes straight from the lock file (only checked for non-empty), so a lock named#{system("...")}ran arbitrary Ruby whencinc-client -zloaded the export.The fix quotes the name with a single-quoted Ruby literal, the same way
node bootstrapalready quotes itsclient.rbvalues. That helper moves fromcli/remoteinto a small sharedcli/rubylitpackage so both generators use one implementation.Test plan
TestClientRBDoesNotInterpolatePolicyNamefails before the fix (output containedpolicy_name "web#{system(\"id\")}'x") and passes afterTestQuotecovers interpolation, quotes, backslashes, emptygo test ./cli/rubylit/ ./cli/policyfile/ ./cli/remote/,go vet,gofmtclean