Repository navigation
refactor: use cinc-api v0.15.1's scalar attribute and server message helpers - #266
Merged
Merged
Conversation
…helpers node ssh --attribute cloud used to hand SSH Go's map text as the host, because AttributeString formatted an object value. Use AttributeScalar and, for an object, suggest dotted paths inside it. The ACL error explainer's own serverMessage now delegates to ErrorResponse.ServerMessage. Signed-off-by: Tim Smith <tsmith84@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up two cinc-api v0.15.1 helpers (
mainalready requires v0.15.1).node ssh --attribute cloudused to hand SSH Go'smap[...]text as the host name, becauseAttributeStringformatted an object value. It now usesNode.AttributeScalar. When the attribute is an object, the error names a few dotted paths inside it, e.g.--attribute cloud.public_hostname.serverMessagedelegates toErrorResponse.ServerMessage.Test plan
TestNodeSSHHostRejectsNonScalarAttributefails before the change and passes aftergo test ./apps/cinc/cmd/,go vet,gofmt