Conversation
next up is doing it for multiple values, etc.
I want to just use __tls_get_addr directly (or rather llvm.threadlocal.address), but there may or may not be JIT issues.
doesn't really matter since LLVM pointers are opaque now, but I appreciate more clarity
speed up type boundaries a little. all the intrinsic accomplished was a type check, but we only use object-to-float conversion when we know it's the right type (or don't care) so a type check is unnecessary.
into the ThreadLocalState object.
llvm.threadlocal.address also has memory(none), which will be trickier to put together
it's still not enough to convince LLVM to merge calls, though.
that's about it for direct multiple values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves most thread-local-storage access in compiled Lisp code out of intrinsics, which means fewer separate accesses to TLS, which hopefully means a bit more speed.