-
Notifications
You must be signed in to change notification settings - Fork 4
feat(auth): replace Skills callout on OAuth success page with command cards #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eatmorespinach
wants to merge
2
commits into
main
Choose a base branch
from
drew/auth-success-page-copy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "clerk": patch | ||
| --- | ||
|
|
||
| Replace the Clerk Skills install box on the sign-in success page with three command cards — install, customize, and deploy — showing what the CLI can do right after authentication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: clerk/cli
Length of output: 4570
🌐 Web query:
MDN Document execCommand returns boolean false command not supported💡 Result:
The document.execCommand method returns a boolean value, which is false if the command is unsupported, disabled, or fails to execute [1][2][3]. It is important to note that a return value of false does not definitively prove that a browser lacks support for a command, nor can execCommand be used to verify browser support before execution [1][2]. This is because the method only returns true if it is successfully invoked as part of a trusted user interaction (e.g., a click event) [1][4]. If called outside of such an interaction, it may return false even if the command is otherwise supported [1][4]. To accurately check if a specific command is supported by the browser, you should use the document.queryCommandSupported(command) method [5][6]. Key takeaways regarding execCommand behavior: 1. Return Value: It returns true only if the command was successfully executed as part of a user-initiated action [1][2]. It returns false if the command is unsupported, disabled, or if the environment does not allow the action (such as lack of user permission) [1][7]. 2. Reliability: Because it requires user interaction, you cannot use the return value of execCommand to test for feature support [1]. 3. Recommended Practice: Use document.queryCommandSupported to check for support [5][6], and note that document.execCommand is a deprecated and non-standard feature that should be avoided in modern web development in favor of standard alternatives like the Clipboard API [2][6].
Citations:
Check the fallback result before showing success.
When
document.execCommand('copy')returnsfalse, the fallback still callsdone(). The button can then report success even though the copy operation failed. Calldone()only when the return value istrue.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents