Skip to content

fix(ui): clear the invitation ticket when a sign-in completes on a challenge - #9621

Open
zourzouvillys wants to merge 1 commit into
theo/resume-enterprise-sso-after-challengefrom
theo/ticket-param-after-challenge
Open

fix(ui): clear the invitation ticket when a sign-in completes on a challenge#9621
zourzouvillys wants to merge 1 commit into
theo/resume-enterprise-sso-after-challengefrom
theo/ticket-param-after-challenge

Conversation

@zourzouvillys

Copy link
Copy Markdown
Contributor

Description

Stacked on #9620 — review the delta only; that one merges first.

A sign-in started from an organization invitation clears the ticket from the URL when it completes. If a verification challenge is required, the sign-in completes on the challenge instead, which did not clear it — so the ticket stayed in the address bar afterwards.

Clear it there too, matching what the start page and the sign-up flow already do.

Effects and risks

  • removeClerkQueryParam is a no-op when the parameter is absent, so this only affects the ticket case.
  • Only covers a sign-in that completes on the challenge itself. One that continues to another step and completes there keeps the parameter, as it does today without a challenge — unchanged here.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Sep 1, 2026 1:07am UTC
swingset Ready Ready Preview Sep 1, 2026 1:07am UTC

Request Review

@changeset-bot

changeset-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 31e46ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/ui Patch
@clerk/chrome-extension Patch
@clerk/swingset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Aug 31, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9621

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9621

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9621

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9621

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9621

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9621

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9621

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9621

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9621

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9621

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9621

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9621

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9621

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9621

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9621

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9621

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9621

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9621

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9621

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9621

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9621

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9621

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9621

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9621

commit: 31e46ed

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-09-01T01:09:56.284Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 0
🔴 Breaking changes 0
🟡 Non-breaking changes 0
🟢 Additions 0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 31e46ed.

…allenge

A ticket sign-in that would have completed on the start page completes
on the challenge instead, which did not clear the ticket from the URL.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant