Skip to content

test(mosaic): drop UserButton layer tests covered by the integration suite - #9847

Merged
alexcarpenter merged 1 commit into
carp/mosaic-intergration-testsfrom
carp/mosaic-trim-user-button-tests
Sep 22, 2026
Merged

alexcarpenter merged 1 commit into
carp/mosaic-intergration-testsfrom
carp/mosaic-trim-user-button-tests

Conversation

@alexcarpenter

Copy link
Copy Markdown
Member

Description

Stacked on #9846.

First step in moving the Mosaic UserButton tests toward "mostly integration". This removes three test files that test internal layers in isolation (useUserButtonController, resolveUserButtonLayout, and the UserButton wrapper with every layer mocked). The connected integration suite already exercises the same behavior through the real popover.

Coverage of src/features/user-button is unchanged without them (375/380 statements, 327/345 branches). The two wrapper behaviors the integration suite did not cover, showing the fallback while Clerk loads and dropping it once nobody is signed in, now live there.

Follow-ups will fold the use cases in the view and model tests into the integration suite and remove the rest.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Sep 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a703c0e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Sep 21, 2026 9:14pm UTC
swingset Ready Ready Preview Sep 21, 2026 9:14pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Team

Run ID: bcc9e17b-9ec5-48f2-97b4-49b10711a289

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@alexcarpenter
alexcarpenter merged commit 0bf9b07 into carp/mosaic-intergration-tests Sep 22, 2026
10 checks passed
@alexcarpenter
alexcarpenter deleted the carp/mosaic-trim-user-button-tests branch September 22, 2026 11:18

This branch was successfully deployed

2 active deployments
Preview – swingset — a703c0ea Deployed Sep 21, 2026 by vercel[bot]
Preview – clerk-js-sandbox — a703c0ea Deployed Sep 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants