Repository navigation
test(mosaic): drop UserButton layer tests covered by the integration suite - #9847
Conversation
🦋 Changeset detectedLatest commit: a703c0e The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
0bf9b07
into
carp/mosaic-intergration-tests
Description
Stacked on #9846.
First step in moving the Mosaic
UserButtontests toward "mostly integration". This removes three test files that test internal layers in isolation (useUserButtonController,resolveUserButtonLayout, and theUserButtonwrapper with every layer mocked). The connected integration suite already exercises the same behavior through the real popover.Coverage of
src/features/user-buttonis unchanged without them (375/380 statements, 327/345 branches). The two wrapper behaviors the integration suite did not cover, showing thefallbackwhile Clerk loads and dropping it once nobody is signed in, now live there.Follow-ups will fold the use cases in the view and model tests into the integration suite and remove the rest.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change