Skip to content

test(e2e): run composed profile suites against the bundled UI app - #9990

Open
alexcarpenter wants to merge 6 commits into
mainfrom
carp/composed-flakes
Open

alexcarpenter wants to merge 6 commits into
mainfrom
carp/composed-flakes

Conversation

@alexcarpenter

@alexcarpenter alexcarpenter commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Description

Fixes flaky @generic runs caused by the composed profile suites. Each suite built and booted its own Next.js app in beforeAll with an extra @clerk/ui install (21–27s on CI), then waited on the first next dev compile, which regularly exceeded the 30s hook timeout. When that happened the dev server was never killed, loading the shared runner and slowing unrelated suites.

  • The composed tests (integration/tests/composed/) now run against the existing next.appRouterBundledUI long-running app, which already depends on @clerk/ui. The composed pages live in the next-app-router-bundled-ui template, so the suites no longer boot an app or need custom hook timeouts.
  • Adds a composed CI job (test:integration:composed, @composed tag) that runs these suites against the bundled UI app, in both the PR and staging e2e matrices (they previously ran inside generic, which is in both). The template's themes page is updated from the removed baseTheme appearance prop to theme so the app builds.
  • integration/models/application.ts: dev() and serve() register the process kill right after spawning instead of after the server responds, so a beforeAll timeout during startup no longer leaves a dev server running (previously causing ENOTEMPTY on teardown).

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other: test infrastructure

@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Sep 30, 2026 12:16am UTC
swingset Ready Ready Preview Sep 30, 2026 12:16am UTC

Request Review

@changeset-bot

changeset-bot Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 40bbaf4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Team

Run ID: 2ef1a756-8cd8-4506-a517-b6a5023e8114

📥 Commits

Reviewing files that changed from the base of the PR and between 3e6218f and 40bbaf4.

📒 Files selected for processing (1)
  • .github/workflows/e2e-staging.yml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. 7 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.


📝 Walkthrough

Walkthrough

The dev and serve paths now register process cleanup before waiting. The bundled UI template adds composed user and organization profile routes and updates its sign-in theme examples. Playwright suites cover composed profile and security flows, replacing the previous composed-components test file. The package script, Turbo task, and CI matrices add composed integration-test support.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: wobsoriano

Merge Risk: ⚪ Minimal · up to 40bba

The composed staging leg is wired to tasks present at the reviewed head. Compatibility with older release refs remains unverified, but no concrete merge-blocking failure is established.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 23 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: running composed profile end-to-end suites against the bundled UI app.
Description check ✅ Passed The description directly explains the flaky test issue and the changes to test execution, CI matrices, app templates, and process cleanup.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 23 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9990

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9990

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9990

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9990

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9990

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9990

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9990

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9990

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9990

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9990

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9990

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9990

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9990

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9990

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@9990

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9990

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9990

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9990

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9990

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9990

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9990

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9990

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9990

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9990

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9990

commit: 40bbaf4

@alexcarpenter alexcarpenter changed the title test(e2e): give app-boot hooks a 90s budget and always tear down dev servers test(e2e): stop composed suite timeouts from leaking dev servers Sep 29, 2026
@alexcarpenter alexcarpenter changed the title test(e2e): stop composed suite timeouts from leaking dev servers test(e2e): run composed profile suites against the bundled UI app Sep 29, 2026
# Conflicts:
#	integration/tests/composed-components.test.ts

@wobsoriano wobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a q

Comment thread .github/workflows/ci.yml
test-name:
[
'generic',
'composed',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to add composed in e2e-staging test matrix too?

This branch was successfully deployed

2 active deployments
Preview – swingset — 40bbaf4d Deployed Sep 30, 2026 by vercel[bot]
Preview – clerk-js-sandbox — 40bbaf4d Deployed Sep 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants