test(e2e): run composed profile suites against the bundled UI app - #9990
alexcarpenter wants to merge 6 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 40bbaf4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: This review used your included allowance. 7 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour. 📝 WalkthroughWalkthroughThe dev and serve paths now register process cleanup before waiting. The bundled UI template adds composed user and organization profile routes and updates its sign-in theme examples. Playwright suites cover composed profile and security flows, replacing the previous composed-components test file. The package script, Turbo task, and CI matrices add composed integration-test support. Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to The composed staging leg is wired to tasks present at the reviewed head. Compatibility with older release refs remains unverified, but no concrete merge-blocking failure is established. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 23 files. (1 skipped: 1 unsupported.)
Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
ace9b68 to
4cccc8a
Compare
# Conflicts: # integration/tests/composed-components.test.ts
| test-name: | ||
| [ | ||
| 'generic', | ||
| 'composed', |
There was a problem hiding this comment.
do we want to add composed in e2e-staging test matrix too?
javascript/.github/workflows/e2e-staging.yml
Line 144 in 3e6218f
Description
Fixes flaky
@genericruns caused by the composed profile suites. Each suite built and booted its own Next.js app inbeforeAllwith an extra@clerk/uiinstall (21–27s on CI), then waited on the firstnext devcompile, which regularly exceeded the 30s hook timeout. When that happened the dev server was never killed, loading the shared runner and slowing unrelated suites.integration/tests/composed/) now run against the existingnext.appRouterBundledUIlong-running app, which already depends on@clerk/ui. The composed pages live in thenext-app-router-bundled-uitemplate, so the suites no longer boot an app or need custom hook timeouts.composedCI job (test:integration:composed,@composedtag) that runs these suites against the bundled UI app, in both the PR and staging e2e matrices (they previously ran insidegeneric, which is in both). The template'sthemespage is updated from the removedbaseThemeappearance prop tothemeso the app builds.integration/models/application.ts:dev()andserve()register the process kill right after spawning instead of after the server responds, so abeforeAlltimeout during startup no longer leaves a dev server running (previously causingENOTEMPTYon teardown).Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change