Repository navigation
Assign browser profiles to workspaces (GODM-25) - #23
Merged
Merged
Conversation
# Conflicts: # README.md # apps/desktop/src/components/workspaces/workspace-dialog.tsx # packages/core/src/server/routes/workspaces.ts # packages/core/src/services/workspaces.ts # packages/shared/src/api.ts # packages/shared/src/models.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
You can now assign a browser profile to a workspace after the profile has been created (GODM-25). Before this, a profile's workspace could only be set when creating it.
PATCH /api/browser/profiles/:idacceptsworkspaceId.Workspacegets a derivedbrowserProfileId(its default profile), andWorkspaceInput.browserProfileIdsets it (null= use the global default).How was it tested?
pnpm -r typecheck;pnpm --filter @godmode/desktop build.bun testinpackages/coreafter merging the latestmain: 643 pass, 9 skip, 0 fail.browser-profiles.test.ts: moving a profile into and out of workspaces, how the default is decided in each scope,isDefaulttogether with a move, the fallback for the workspace a profile leaves, and the 400 (global default) and 404 (unknown workspace) cases.workspaces.test.ts:browserProfileIdon create and update, clearing it, and rollback on a rejected profile.Checklist
pnpm typecheckandpnpm testpasscargo clippy/cargo testpass (ifapps/desktop/src-taurichanged) — not changedpackages/sharedandapps/desktop/src/lib/api.tsdocs/ARCHITECTURE.md, README)