Repository navigation
One default browser profile per workspace; new chats use the workspace's default (GODM-35) - #33
Merged
Merged
Conversation
…e's default (GODM-35)
# Conflicts: # apps/desktop/src/pages/browser/browser-page.tsx # apps/desktop/src/pages/chat/chat-conversation.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes GODM-35. The Browser page showed two profiles marked Default (the global default and the workspace's default), and a new chat started with Godmode inside a workspace ignored that workspace's default profile.
One default at a time
PATCH /api/workspaces/:id { browserProfileId }.New chats use the workspace's default
conversations.workspace_id(migration 12, deliberately without a FK so backup restores don't drop chats) records the sidebar workspace a global agent's chat was started in. Workspace agents keep using their own workspace. Unknown workspace ids are ignored.resolveProfileForAgent: the chat's own profile → the agent's pinned profile → the default of the agent's workspace (or else the chat's workspace) → the global default. The desktopagentBrowserProfilemirrors it.POST /api/agents/:id/run), the automation one-prompt card and "Create an agent". The composer's browser chip shows "Default — daniel@solakon.de · Default of the Solakon GmbH workspace" before and after sending.workspace_idon its chats, so they go back to the global default.docs/ARCHITECTURE.mdis updated.How was it tested?
pnpm -r typecheckpasses for shared, core and desktop.pnpm build:uibuilds.bun testinpackages/coreafter mergingmain: 696 pass, 0 fail.workspaces.test.ts: a global agent's chat browses with the default of the workspace it was started in; an explicit pick wins; workspace agents and unknown workspaces are ignored; deleting the workspace resets the chat.mcp.test.ts: delegation keeps the caller's workspace and its chat-picked profile.