Repository navigation
GODM-47: Fix the folder picker footer overlap and long-path clipping - #62
Merged
Merged
Conversation
…no longer clip the dialog The footer held the keyboard hints, the native picker button, Cancel and Use in one row. With a longer folder name the hints slid under "Open Finder…" and the name was cut off. - The footer is one row of actions: the native picker on the left, Cancel and Use on the right. Use shows its shortcut and the full folder name. - The Enter and Backspace hints sit in the filter row while it is empty. - The "can't use this folder" notice sits above the footer inside the fixed-height list area, so the dialog keeps its size when it appears. - The dialog column can no longer grow past the dialog: a deep path used to push Cancel and Use out of view. - The description is left-aligned on phones, like the title.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes GODM-47: the "Work in a folder" dialog broke as soon as the folder name got a little longer.
The footer held the keyboard hints, the native picker button, Cancel and Use in one row. The hints were allowed to shrink below their own width, so in the desktop app they slid under "Open Finder…", and the folder name in the Use button was cut off at 11rem.
⌘↵shortcut.Only
apps/desktop/src/components/chat/folder-picker.tsxchanges.docs/screenshots/folder.pngstill shows the old hint strip in the footer.How was it tested?
pnpm typecheck,pnpm test(1393 pass, 0 fail),pnpm --filter @godmode/desktop build⌘↵hint overlaps "Open Finder…" and the name is clipped; with a deep path the footer is 726px wide inside a 576px dialog. After: no overlap or overflow in any state, and the dialog height stays 579px with and without the notice.Checklist
pnpm typecheckandpnpm testpasscargo clippy/cargo testpass (ifapps/desktop/src-taurichanged) — not changedpackages/sharedandapps/desktop/src/lib/api.ts— nonedocs/screenshots/folder.pngnot regenerated