Repository navigation
Fix what the review of spend and budgets found - #63
Merged
Merged
Conversation
- A run is held only when it would start now: a queued run no longer takes the chat's pause while another run in that chat works (that run could fail when it asked a question, and couldn't be paused). - A stretch is booked once, after its pause is saved. - "Let it run", Run now and the human continuing a run keep it past a used-up budget through later pauses (migration 55: paused_runs.exempt); what such a run hands over is exempt too. - A follow-up's "Continue now" and an app/webhook automation's Run now (test event) aren't held. - Messages from Slack, Telegram or Teams are held like unattended work, so nobody in a channel spends past the owner's budget; they're told the chat is on hold. - Held work is looked at again only when a budget amount changes (a restore no longer lets holds go by themselves); a run still held by the other budget shows that budget, and "Raise budget" opens the right one. - The meter counts only held runs it can let run; Send now in a held chat says it lets the run past the budget; Claude is told the turn was held, not paused by the human; runs cut off by a crash are booked at the next start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
takes the chat's pause while another run in that chat works (that run
could fail when it asked a question, and couldn't be paused).
used-up budget through later pauses (migration 55: paused_runs.exempt);
what such a run hands over is exempt too.
(test event) aren't held.
so nobody in a channel spends past the owner's budget; they're told the
chat is on hold.
restore no longer lets holds go by themselves); a run still held by the
other budget shows that budget, and "Raise budget" opens the right one.
chat says it lets the run past the budget; Claude is told the turn was
held, not paused by the human; runs cut off by a crash are booked at the
next start.
Checks
pnpm typecheck: all packages pass