Repository navigation
Fix what the review of Continue / Try again found - #70
Merged
Merged
Conversation
- A chat on a runner can be picked up: retry is forwarded to the runner (which gets what it needs first). - An automation's run is run again by the automation (Run now), so its busy check, events and Needs you follow. - Messages waiting in a chat are sent or removed before a retry (they'd go along unasked). - A ticket's chat is recognised by its origin, also when the ticket is archived. - A VM that couldn't start gets its own advice; VMs that are off keep theirs. - Phone: the strip hides where the desktop does, one request at a time, a stale answer refreshes quietly; live step labels are plain words again; a run that already ended doesn't come back as working. - Quoted error text can't close Godmode's notes: tags are stripped until none is left, angle brackets neutralised. - The stop sentence comes from one place; the bar is announced to screen readers and shows when it is busy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #66, fixing every finding of its review.
Major
/retrywasn't in the runner routing table, so the local handler refused with "This chat works on a runner". It is forwarded now, withprepareRemoteMessagefirst, as for messages. New case inremote-e2e.test.ts: a failed runner turn is tried again from here (201,again).Minor
automation). The desktop offers the automation's own Run now and Open automation instead, so its busy check, condition baseline and "Needs you" follow the new run, and the work can't happen twice.queued), because they would go along unasked. The phone strip hides then, like the desktop bar.origin === "task", so archived tickets and still-loading boards no longer flash a Continue that the core refuses.RunEnd.off). The dead per-run budget pattern is gone.staleanswer refreshes the chat quietly instead of alerting.toolActivityagain ("Running a command", not "Using Bash"). The old-core detection is now "no trailing …".stripNoteTagsrepeats until nothing changes, so<</godmode-x>/godmode-continue>no longer leaves a tag behind.RUN_STOPPED_BY_USERreplaces the remaining literals.aria-live="polite", and its buttons and the phone's expose a busy state.Not changed (review's open question): a child chat stopped because its parent paused still offers Continue. The human may want just that work, and the answer goes to them in that chat.
Checks: