Skip to content

Workaround string_view abi mismatch - #43

Merged
matthiasdiener merged 2 commits into
conda-forge:mainfrom
jschueller:sview2
Jun 24, 2026
Merged

matthiasdiener merged 2 commits into
conda-forge:mainfrom
jschueller:sview2

Conversation

@jschueller

@jschueller jschueller commented Jun 13, 2026 •

Copy link
Copy Markdown
Contributor

A similar issue than open-source-parsers/jsoncpp#1661
force build in c++17 mode to always enable string_view, so cmake detection succeeds and definition always matches client code
xref open-source-parsers/jsoncpp#1676

@conda-forge-admin please rerender

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@jschueller
jschueller marked this pull request as ready for review June 13, 2026 17:47
@jschueller

Copy link
Copy Markdown
Contributor Author

@conda-forge-admin please restart ci

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/27474386466. Examine the logs at this URL for more detail.

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/27474396848. Examine the logs at this URL for more detail.

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/27474428043. Examine the logs at this URL for more detail.

@jschueller

Copy link
Copy Markdown
Contributor Author

hello @conda-forge/jsoncpp could someone review ? this is blocking paraview

@matthiasdiener
matthiasdiener merged commit df2dbcd into conda-forge:main Jun 24, 2026
13 checks passed
@matthiasdiener

Copy link
Copy Markdown
Contributor

hello @conda-forge/jsoncpp could someone review ? this is blocking paraview

Thanks @jschueller, and sorry for the delay. Out of curiosity, is this fix only necessary on Windows?

@jschueller
jschueller deleted the sview2 branch June 24, 2026 18:13
@jschueller

Copy link
Copy Markdown
Contributor Author

it seems it can happen on linux too: open-source-parsers/jsoncpp#1595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants