[fix][model] read default parameter values from config - #656
Open
oleg-ai-dev wants to merge 4 commits into
Open
Conversation
|
|
1 similar comment
|
|
oleg-ai-dev
force-pushed
the
fix/125-model-default-value
branch
2 times, most recently
from
September 9, 2026 21:41
05edd95 to
31fb186
Compare
oleg-ai-dev
force-pushed
the
fix/125-model-default-value
branch
from
September 9, 2026 21:48
31fb186 to
f6c2968
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title
[<type>][<scope>] <description>.(Optional) More detailed description for this PR
en:
The shipped Docker Compose and Helm
model_config.yamlfiles define parameter defaults with thedefault_valkey.ParamSchemaoriginally decoded onlydefault_value, so Viper left every shipped default empty and the model-management response did not expose those defaults.This change decodes
default_valas the canonical shipped spelling while preservingdefault_valuefor backward compatibility with existing custom configurations. The alias is normalized from the same Viper snapshot, so live reloads cannot return mixed configuration versions. When both keys are present,default_valtakes precedence; the public JSON field remainsdefault_value.A regression test loads real YAML through the production Viper factory and verifies both spellings, nested parameter schemas, and deterministic precedence. A second test verifies normalization uses a single loader snapshot and removes the internal alias before returning the model.
Validation
go test -count=1 ./modules/llm/infra/configgo test -count=1 ./modules/llm/...go vet ./modules/llm/...go build ./modules/llm/...git diff --check(Optional) Which issue(s) this PR fixes
Fixes #125