Match newlines in gitignore globstar path segments - #139
Merged
cpburnz merged 1 commit intoSep 10, 2026
Conversation
Owner
|
Thanks for finding and fixing this. It dismays me that git actually supports newlines in file names. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patterns such as
target,**/target, androot/**/targetfail to match when a parent directory contains a newline: the generated globstar regex uses a dot without DOTALL.GitIgnoreBasicPatternalso misses a filename consisting only of a newline for*and**.Use scoped DOTALL for globstar segments and the basic match-all shortcut. Update literal regex expectations, add newline regressions, and include a changelog entry. Matching ordinary segment characters remains unchanged.
Validation: new regressions fail before the change; 214 tests and 652 subtests pass with simple, RE2, and Hyperscan backends on CPython 3.12.14. Five cases were independently checked against
git check-ignore --stdin -zin real temporary repositories; Git and all three backends agree.Implemented and locally validated with OpenAI Codex.
Issue tracking: Found during source inspection; no matching open issue was identified for this fix.