Repository navigation
feat(resolver): add opt-in upstream SHA provenance verification - #61
Merged
Merged
Conversation
narenaryan
marked this pull request as ready for review
October 8, 2026 21:57
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #58. Adds an opt-in
--verify-provenancepath shared by audit, autofix, upgrade and upgrade-all-sha. Existing immutability-only defaults remain unchanged.Validation
Run with the approved official Go 1.26.9 toolchain:
gofmton changed Go files; formatting check cleango test ./...passed across all six packagesgo vet ./...passedgo test -race ./...passed across all six packagesgo build ./...passedgit diff --checkpassed57a0ca9cec1d6e0a0cfacd88bfaa0a832dfeecc7goimports,golangci-lintandgovulncheckwere unavailable and were not downloaded. Their checks have not run locally. The initial head passed GitHub Actions unit tests, Semgrep, binary-size comparison and Semaphore's Scharf CI pipeline. The revised head below is being checked separately.Deliberate limits / review points
Verification means point-in-time reachability from current upstream branch histories, not benign code or trusted maintainers. Tag-only releases and deleted/rewritten histories can remain unverified. Identity history is trust-on-first-use in the local observation file. Suspicious re-baselining remains a manual review step.
This covers directly scanned workflow references. Recursive dependency provenance and combining verification with the separately proposed dependency-graph audit are unsupported; integration of the parallel #56 work must retain an explicit combined-mode guard.
See
docs/provenance.mdand ADR 005 for the evidence model, limits and review process. Keep this PR in draft for maintainer review; this description intentionally does not auto-close #58.AI bug-pattern reassessment (October 8, 2026)
Applied
ai-bug-patternsto TOCTOU, fail-closed, cache/history and alternate command paths. Two reproduced bug classes are fixed:33 regression scenarios cover stale/added/removed workflows, requested/canonical identity replacement, final-check failures, history preservation and exhausted request budgets. Full unit/race tests, vet, build, module verification, formatting and whitespace checks pass on tree
c1562a3ed121bea85bcab396dbe08b650d68eca1. Revised heade6e3ce17be51a5bf09209b244eee57184721dd63passed GitHub unit tests, Semgrep, binary-size comparison and Semaphore.Limits remain explicit: GitHub API calls are not an atomic snapshot and cannot detect an ABA identity transition between reads; filesystem checks do not lock the working tree or make multi-file writes transactional. No live action payload was executed or additional tool installed.
The revised #61/#62 heads also form conflict-free local merge-tree
7d43701bcf888efe312e26ac33c98f436c2cef29, which passed unit tests, race tests and vet, plus an archive build with-buildvcs=false. This is integration evidence only; no PR was merged.