build: update 'src/dashbls' to dashpay/bls-signatures@d36c482e - #7608
Draft
PastaPastaPasta wants to merge 4 commits into
Draft
build: update 'src/dashbls' to dashpay/bls-signatures@d36c482e#7608PastaPastaPasta wants to merge 4 commits into
PastaPastaPasta wants to merge 4 commits into
Conversation
d36c482edfe9 fix: cleanse BIP32 secret derivation state git-subtree-dir: src/dashbls git-subtree-split: d36c482edfe95c4e1db50dd60c2e53c95037c519
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Dash Core's wallet-derived masternode operator-key work makes
ExtendedPrivateKeypart of a production wallet-secret path. The required BLS secret-lifecycle hardening belongs upstream indashpay/bls-signatures, not as direct edits to Dash Core's vendored subtree.This draft is stacked on dashpay/bls-signatures#127 and must not merge before that upstream PR.
What was done?
dashpay/bls-signatures@d36c482eusing the repository's normal subtree history.relic_conf.h.inhandling around the subtree merge.The upstream change wipes BIP32 chain codes, private-key scalar storage, HMAC inputs and outputs, and intermediate RELIC scalars on replacement and destruction, with exception-safe storage and lifecycle tests.
How Has This Been Tested?
make -j6make -C src/dashbls runtest: 1,418 assertions across 17 cases passedmake -C src/dashbls checksrc/test/test_dash --run_test=bls_tests: 20 cases passedtest/lint/git-subtree-check.sh src/dashbls 0a0e49780f94: passedtest/lint/lint-whitespace.pytest/lint/lint-includes.pygit diff --checkBreaking Changes
None expected.
Checklist
This pull request was created by Codex.