Skip to content

build: update 'src/dashbls' to dashpay/bls-signatures@d36c482e - #7608

Draft
PastaPastaPasta wants to merge 4 commits into
dashpay:developfrom
PastaPastaPasta:build/update-dashbls-secret-cleansing
Draft

build: update 'src/dashbls' to dashpay/bls-signatures@d36c482e#7608
PastaPastaPasta wants to merge 4 commits into
dashpay:developfrom
PastaPastaPasta:build/update-dashbls-secret-cleansing

Conversation

@PastaPastaPasta

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

Dash Core's wallet-derived masternode operator-key work makes ExtendedPrivateKey part of a production wallet-secret path. The required BLS secret-lifecycle hardening belongs upstream in dashpay/bls-signatures, not as direct edits to Dash Core's vendored subtree.

This draft is stacked on dashpay/bls-signatures#127 and must not merge before that upstream PR.

What was done?

  • Imported dashpay/bls-signatures@d36c482e using the repository's normal subtree history.
  • Preserved Dash Core's generated relic_conf.h.in handling around the subtree merge.
  • Kept the Core diff byte-for-byte limited to the six files changed upstream.

The upstream change wipes BIP32 chain codes, private-key scalar storage, HMAC inputs and outputs, and intermediate RELIC scalars on replacement and destruction, with exception-safe storage and lifecycle tests.

How Has This Been Tested?

  • Full Dash Core make -j6
  • make -C src/dashbls runtest: 1,418 assertions across 17 cases passed
  • make -C src/dashbls check
  • src/test/test_dash --run_test=bls_tests: 20 cases passed
  • test/lint/git-subtree-check.sh src/dashbls 0a0e49780f94: passed
  • test/lint/lint-whitespace.py
  • test/lint/lint-includes.py
  • git diff --check
  • Upstream validation also covered RELIC AUTO with easy/GMP backends and DYNAMIC compilation.

Breaking Changes

None expected.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation (N/A; internal secret-lifecycle hardening)
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

This pull request was created by Codex.

@PastaPastaPasta PastaPastaPasta changed the title depends: update 'src/dashbls' to dashpay/bls-signatures@d36c482e as f6cad94f build: update 'src/dashbls' to dashpay/bls-signatures@d36c482e Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants