Skip to content

chore: follow-ups to the TypeScript 7 migration #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fjakobs wants to merge 5 commits into
base: victor-ditadi_data/typescript-7
Choose a base branch
from
Open

chore: follow-ups to the TypeScript 7 migration #701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7893695
chore: strip JSDoc from bundled JS and use tsdown's deps options
fjakobs Nov 3, 2026
5c90002
fix(appkit): type the server plugin's exports
fjakobs Nov 3, 2026
442d976
fix(playground): typecheck the client
fjakobs Nov 3, 2026
10fa1ff
chore(playground): install the client with pnpm
fjakobs Nov 3, 2026
081f362
chore(deps): bump tsdown to 0.23.2 and drop the rolldown-plugin-dts p…
fjakobs Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3,212 changes: 0 additions & 3,212 deletions apps/clean-app/package-lock.json
View file
Open in desktop

This file was deleted.

6,252 changes: 0 additions & 6,252 deletions apps/dev-playground/client/package-lock.json
View file
Open in desktop

This file was deleted.

44 changes: 21 additions & 23 deletions apps/dev-playground/client/src/routes/data-visualization.route.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,13 @@ function DataVisualizationRoute() {
<AreaChart
queryKey="spend_data"
parameters={spendDataParams}
curveType="natural"
smooth
/>
<CodeSnippet
code={`<AreaChart
queryKey="spend_data"
parameters={spendDataParams}
curveType="natural"
smooth
/>`}
/>
</CardContent>
Expand All @@ -116,13 +116,13 @@ function DataVisualizationRoute() {
<AreaChart
queryKey="spend_data"
parameters={spendDataParams}
curveType="linear"
smooth={false}
/>
<CodeSnippet
code={`<AreaChart
queryKey="spend_data"
parameters={spendDataParams}
curveType="linear"
smooth={false}
/>`}
/>
</CardContent>
Expand Down Expand Up @@ -182,15 +182,15 @@ function DataVisualizationRoute() {
<LineChart
queryKey="spend_data"
parameters={spendDataParams}
curveType="monotone"
showDots={false}
smooth
showSymbol={false}
/>
<CodeSnippet
code={`<LineChart
queryKey="spend_data"
parameters={spendDataParams}
curveType="monotone"
showDots={false}
smooth
showSymbol={false}
/>`}
/>
</CardContent>
Expand All @@ -206,15 +206,15 @@ function DataVisualizationRoute() {
<LineChart
queryKey="spend_data"
parameters={spendDataParams}
curveType="monotone"
showDots={true}
smooth
showSymbol={true}
/>
<CodeSnippet
code={`<LineChart
queryKey="spend_data"
parameters={spendDataParams}
curveType="monotone"
showDots={true}
smooth
showSymbol={true}
/>`}
/>
</CardContent>
Expand Down Expand Up @@ -250,14 +250,14 @@ function DataVisualizationRoute() {
queryKey="top_contributors"
parameters={commonParams}
innerRadius={60}
showLabel={true}
showLabels={true}
/>
<CodeSnippet
code={`<PieChart
queryKey="top_contributors"
parameters={commonParams}
innerRadius={60}
showLabel={true}
showLabels={true}
/>`}
/>
</CardContent>
Expand All @@ -273,37 +273,35 @@ function DataVisualizationRoute() {
<RadarChart
queryKey="spend_data"
parameters={spendDataParams}
fillOpacity={0.6}
showArea
/>
<CodeSnippet
code={`<RadarChart
queryKey="spend_data"
parameters={spendDataParams}
fillOpacity={0.6}
showArea
/>`}
/>
</CardContent>
</Card>

{/* Radar Chart - With Dots */}
{/* Radar Chart - Outline */}
<Card>
<CardHeader>
<CardTitle>Performance Metrics (With Dots)</CardTitle>
<CardDescription>Radar Chart with data points</CardDescription>
<CardTitle>Performance Metrics (Outline)</CardTitle>
<CardDescription>Radar Chart without area fill</CardDescription>
</CardHeader>
<CardContent>
<RadarChart
queryKey="spend_data"
parameters={spendDataParams}
showDots={true}
fillOpacity={0.4}
showArea={false}
/>
<CodeSnippet
code={`<RadarChart
queryKey="spend_data"
parameters={spendDataParams}
showDots={true}
fillOpacity={0.4}
showArea={false}
/>`}
/>
</CardContent>
Expand Down
5 changes: 2 additions & 3 deletions apps/dev-playground/client/src/routes/metric-views.route.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,9 @@ function toDimensionOptions(
* in clicks, which `fromChartName` decodes back to selections.
*/
function normalizeChartDataForChart(
rows: Array<Record<string, unknown>> | null,
rows: Array<Record<string, unknown>>,
dimension: FilterDimension,
): Array<Record<string, unknown>> | null {
if (!rows) return rows;
): Array<Record<string, unknown>> {
return rows.map((row) => {
const value = row[dimension];
let normalized: string;
Expand Down
2 changes: 1 addition & 1 deletion apps/dev-playground/client/src/routes/sql-helpers.route.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ function SqlHelpersRoute() {

const { data, loading, error } = useAnalyticsQuery(
"sql_helpers_test",
queryParams ?? {},
queryParams,
);

// Helper to show the marker result
Expand Down
4 changes: 3 additions & 1 deletion apps/dev-playground/client/tsconfig.app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,10 @@
"erasableSyntaxOnly": true,
"noFallthroughCasesInSwitch": true,
"noUncheckedSideEffectImports": true,
// Mirrors the aliases in vite.config.ts.
"paths": {
"@/*": ["./src/*"]
"@/*": ["./src/*"],
"@databricks/appkit-ui/*": ["../../../packages/appkit-ui/dist/*"]
}
},
"include": ["src", "../shared/appkit-types"]
Expand Down
Loading
Loading