Repository navigation
Conversation
`appkit doctor` only recorded app.yaml env entries with `valueFrom`, so a
literal `{ name: X, value: ... }` entry was reported as ENV_UNWIRED (an
error that fails the run) and the config layer told users to wire a var
that was already wired.
Track every app.yaml env name the platform sets on deploy (`valueFrom` or
a non-null literal `value`) as `wiredEnvVars`, and use it for both checks.
`envToBinding` stays the valueFrom-to-binding join.
Co-authored-by: Isaac <no-reply@databricks.com>
Signed-off-by: Fabian Jakobs <fabian.jakobs@databricks.com>
Contributor
📦 Bundle size reportCompared against
|
| dist | raw | gzip |
|---|---|---|
| JS (runtime) | 1.3 MB | 459 KB |
| Type declarations | 465 KB | 169 KB (-1 B) |
| Source maps | 2.5 MB | 859 KB |
| Other | 11 KB | 3.7 KB |
| Total | 4.2 MB | 1.5 MB (-1 B) |
Per-entry composition (own code — deps external (as shipped))
| Entry | Initial (gz) | Lazy (gz) | Total (gz) | node_modules (min) | Own code (min) |
|---|---|---|---|---|---|
. |
106 KB | 2.5 KB | 109 KB | external | 344 KB |
./beta |
103 KB | 482 B | 104 KB | external | 310 KB |
./testing |
45 KB | 32 KB | 77 KB | external | 223 KB |
./tsdown |
520 B | 0 B | 520 B | external | 813 B |
./type-generator |
26 KB | 0 B | 26 KB | external | 74 KB |
Chunks:
| Entry | Chunk | Load | Size (gz) |
|---|---|---|---|
. |
index.js |
initial | 102 KB |
. |
utils.js |
initial | 4.6 KB |
. |
remote-tunnel-manager.js |
lazy | 2.5 KB |
./beta |
beta.js |
initial | 83 KB |
./beta |
modular.js |
initial | 6.0 KB |
./beta |
stream-manager.js |
initial | 5.9 KB |
./beta |
service-context.js |
initial | 4.2 KB |
./beta |
databricks.js |
initial | 3.3 KB |
./beta |
client.js |
initial | 647 B |
./beta |
index.js |
initial | 20 B |
./beta |
supervisor-api.js |
lazy | 192 B |
./beta |
databricks.js |
lazy | 176 B |
./beta |
index.js |
lazy | 114 B |
./testing |
manifest.js |
initial | 32 KB |
./testing |
index.js |
initial | 10 KB |
./testing |
wide-event-emitter.js |
initial | 2.9 KB |
./testing |
index.js |
lazy | 28 KB |
./testing |
remote-tunnel-manager.js |
lazy | 2.5 KB |
./testing |
utils.js |
lazy | 1.8 KB |
./tsdown |
index.js |
initial | 520 B |
./type-generator |
index.js |
initial | 26 KB |
@databricks/appkit-ui
npm tarball (packed): 397 KB (-4 B) — gzipped download (dist + bin; excludes release-only docs/NOTICE).
| dist | raw | gzip |
|---|---|---|
| JS (runtime) | 429 KB | 147 KB |
| Type declarations | 267 KB | 98 KB (-1 B) |
| Source maps | 853 KB | 286 KB |
| CSS | 16 KB | 3.2 KB |
| Total | 1.5 MB | 534 KB (-1 B) |
Per-entry composition (consumer bundle — deps bundled, peerDeps external)
| Entry | Initial (gz) | Lazy (gz) | Total (gz) | node_modules (min) | Own code (min) |
|---|---|---|---|---|---|
./js |
5.3 KB | 49 KB | 55 KB | 208 KB | 14 KB |
./js/beta |
2.1 KB | 0 B | 2.1 KB | 0 B | 5.0 KB |
./react |
433 KB | 49 KB | 481 KB | 1.3 MB | 177 KB |
./react/beta |
4.9 KB | 0 B | 4.9 KB | 0 B | 12 KB |
Chunks:
| Entry | Chunk | Load | Size (gz) |
|---|---|---|---|
./js |
index.js |
initial | 5.2 KB |
./js |
chunk |
initial | 120 B |
./js |
apache-arrow |
lazy | 49 KB |
./js/beta |
beta.js |
initial | 2.1 KB |
./react |
index.js |
initial | 431 KB |
./react |
tslib |
initial | 2.1 KB |
./react |
apache-arrow |
lazy | 49 KB |
./react/beta |
beta.js |
initial | 4.9 KB |
Contributor
🤖 AppKit PR bot🔬 Run evalsStart an eval for this PR from the evals-monitor app: Go to Evals Monitor → 📦 Try this PR's app templateScaffolds a new app from this PR's SDK build. Run it in any folder (requires the GitHub CLI — gh run download 42241719596 -R databricks/appkit -n appkit-template-0.90.0-pr.dfdee7a-fjakobs-la-2050-doctor-literal-env-value-710 -D appkit-pr-710 \
&& unzip -o "appkit-pr-710/appkit-template-0.90.0-pr.dfdee7a-fjakobs-la-2050-doctor-literal-env-value-710.zip" -d "appkit-pr-710" \
&& databricks apps init --template "appkit-pr-710"The template pins |
MarioCadenas
approved these changes
Nov 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
appkit doctorreports an app.yaml env entry with a literalvalue:as unwired. For example, this entry is valid and sets the variable on deploy:Doctor still fails the run on it:
When the var is also missing from the local
.env, the config check adds the hint "wire it through app.yaml + databricks.yml for deploy", even though app.yaml already wires it.Root cause
readBundleInfo(doctor/bundle.ts) only recorded app.yaml env entries that havevalueFrom, inenvToBinding. Two checks treated "is inenvToBinding" as "app.yaml sets this var":ENV_UNWIREDinchecks-wiring.ts, which caused the false error.wiredEnvVarsfor the config layer inrun.ts, which caused the misleading hint.Fix
BundleInfogetswiredEnvVars, the app.yaml env names the platform sets on deploy: those withvalueFromor a non-null literalvalue.value: ""counts as wired, because it does set the var.value:(YAML null) doesn't count.ENV_UNWIREDand the config-layer hint both usewiredEnvVars.envToBindingis unchanged: it's still thevalueFrom→ binding join used byVALUEFROM_UNBOUNDand provenance.external, so the live existence probe still checks the literal ID.ENV_UNWIREDdescription now covers literal values.Tests
checks-wiring.test.ts: a required plugin env var that app.yaml sets with a literal value produces no findings.bundle.test.ts:valueFromand literal entries (includingvalue: "") are wired, a nullvalueisn't, and literals stay out ofenvToBinding.Verification
I built a minimal app (Genie plugin) whose app.yaml sets the space ID with a literal
value:pointing at an existing Genie space, then ran the builtappkit doctor --profile <profile>against a Databricks workspace:value:entry✗ … has no app.yaml entry, exit 1✓ Auth,✓ Genie Space,2 ok, exit 0.envENV_UNWIREDENV_UNWIREDENV_UNWIREDstill reported, exit 1These pass:
pnpm build,pnpm docs:build,pnpm check:fix,pnpm -r typecheckandpnpm test(309 files, 5929 tests).This pull request and its description were written by Isaac.