Repository navigation
Stop DBFS iteration at EOF after file truncation - #1621
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
Signed-off-by: Kayvan Zahiri <kzahiri@dons.usfca.edu>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a DBFS file is truncated after
get_status,_DbfsIO.__iter__continues using the cached size. An empty read does not advance the offset, so both iteration andread()keep requesting EOF indefinitely.Stop iteration on an empty chunk. This preserves the existing direct
read(size)and__next__behavior and returns the bytes read before EOF.Validation: eight public
WorkspaceClient.dbfs.openHTTP-mocked cases cover empty/nonempty files, accurate/stale sizes, and iteration/read consumption. Four stale-size cases fail before the fix; all eight pass after it. All 22 DBFS mixin tests pass. Repository-wide Ruff lint and formatting checks pass, as doesgit diff --check. The full suite passes: 2,312 tests on Python 3.12 (13 warnings). No hosted Databricks workspace or full Python/OS matrix was used.I understand this repository is a public mirror and maintainers re-apply accepted external changes internally.