Repository navigation
fix: don't treat scaladoc warnings as fatal so publishM2Local succeeds - #1033
Merged
Merged
Conversation
`scalaDocGenerated` derives its options solely from `scalaDocOptions`, whose Mill default folds in `scalacOptions` — which include the fatal-warning flags (`-Werror`, and `-Xfatal-warnings` on 2.12). As a result `docJar` (and therefore `publishM2Local`) failed on the ~93 scaladoc-only warnings: cross-links to external libraries not on the doc classpath (e.g. `upickle.core.Visitor`, `ujson.Value`) and doc comments on the per-builtin entries inside the stdlib `Seq` literals. Override `scalaDocOptions` to strip the fatal-warning flags for doc generation only. Compilation stays strict (`-Werror` still applies to `compile`). `./mill 'sjsonnet.jvm[_].publishM2Local'` now succeeds and emits `-javadoc.jar` for Scala 3.3.7, 2.13.18, and 2.12.21. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Override
scalaDocOptionsto strip the fatal-warning flags for doc generation only. Compilation stays strict (-Werrorstill applies tocompile)../mill 'sjsonnet.jvm[_].publishM2Local'now succeeds and emits-javadoc.jarfor Scala 3.3.7, 2.13.18, and 2.12.21.