Repository navigation
Remove legacy unauthenticated Pipedrive actions - #121
Merged
Merged
Conversation
`pipedrive.createSalesLead` and `pipedrive.createPartnerProgramLead` were superseded by the `forms.*` actions in "New forms management" (699fb3a) but stayed exported in the public action manifest. They accepted a `token` field that was never validated and wrote directly to Pipedrive with the server token, so any anonymous caller could create organizations, people, leads and notes in the CRM. No frontend code calls them anymore. Keep `pipedrive/utils.ts` and `PipedriveClient.ts`, which the form actions still use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete the two legacy Astro actions
pipedrive.createSalesLeadandpipedrive.createPartnerProgramLeadand drop thepipedrivegroup from the exported action manifest.These were replaced by the Turnstile-protected
forms.*actions in "New forms management" (699fb3a) but were never removed. They accepted atokenfield that was never validated and ran the full Pipedrive write chain (organization, person, lead, note) with the server-sidePIPEDRIVE_TOKEN, so any anonymousPOSTto/_actions/pipedrive.*could inject records into the CRM. An external researcher reported this; see the Basecamp card https://app.basecamp.com/5656352/buckets/33604800/card_tables/cards/10300577258.A code search found no caller of either action.
src/actions/pipedrive/utils.tsandPipedriveClient.tsstay, since the form actions import them.After deploy the two
/_actions/pipedrive.*URLs return 404 like any unknown action.Validation:
astro checkpasses with 0 errors and 0 warnings (881 files).Not covered here: auditing Pipedrive for junk records created via these endpoints since November 2025.