[BUG] Icons from ~/.local/share/icons and /usr/share/icons/HighContrast not displayed

[rileyophus]

Rofi version (rofi -v or git commit in case of build issue)

2.0.0

Configuration

https://gist.github.com/rileyophus/8cfdacbd2c2de6079f15565ee86fc13e

Theme

https://gist.github.com/rileyophus/7bbac9c6042eb9c329e9f75fde7ea188

Timing report

No response

Launch command

rofi -show drun

Step to reproduce

1. Choose icon (in my case, a PNG) from ~/.local/share/icons/hicolor/<some resolution>/apps/
2. Create .desktop file (in ~/.local/share/applications/) with the Icon field set to the basename of that icon file (minus file extension)
3. Run rofi -show drun

Expected behavior

Icon is properly displayed

Actual behavior

Icon is not displayed

Additional information

If the procedure to reproduce is followed but ~/.local/share/icons/hicolor is replaced with /usr/share/icons/hicolor, the icon is properly displayed. If the Icon field is set to the full path of the icon, the icon is properly displayed. Icons from flatpaks, which are not located in ~/.local/share/icons/ but instead ~/.local/share/flatpak/app/<flatpak name>/current/active/files/share/icons/, are displayed properly.

I've checked if the issue exists in the latest stable release

• Yes, I have checked the problem exists in the latest stable version

[DaveDavenport]

Works fine for me:

(process:231029): Helpers.IconFetcher-DEBUG: 07:19:10.083: found icon VictronConnect(124x124): /home/qball/.local/share/icons/hicolor/128x128/apps/VictronConnect.png

Did you correctly setup your environment? What does g_get_user_data_dir() (XDG_DATA_HOME) resolve too?

[rileyophus]

Did you correctly setup your environment? What does g_get_user_data_dir() (XDG_DATA_HOME) resolve too?

I don't know where the g_get_user_data_dir function lives or how to call it. XDG_DATA_HOME isn't set, but that shouldn't matter because the XDG standard says when it's unset, $HOME/.local/share should be used anyway.

[DaveDavenport]

g_get_user_data_dir is the glib (everything gtk/gnome) uses to get that XDG data dir, and follows the XDG spec.

Rofi follows this standard, and on my system seems to find icons in that directory just fine.
I've checked the library rofi uses to resolve icons, and that seems to be handling it correctly.

Can you pastebin a trace with debugging information? (see man rofi-debugging)

echo -en "test\x00icon\x1frofi" | G_MESSAGES_DEBUG=Helpers.IconFetcher rofi -dmenu

where you replace rofi (icon name) with an icon in your ~/.local/share/icons/ directory.

An example (for me) is:

(process:33512): Helpers.IconFetcher-DEBUG: 18:00:16.266: starting up icon fetching thread.
(process:33512): Helpers.IconFetcher-DEBUG: 18:00:16.266: Query: go-next(16)
(process:33512): Helpers.IconFetcher-DEBUG: 18:00:16.266: starting up icon fetching thread.
(process:33512): Helpers.IconFetcher-DEBUG: 18:00:16.267: found icon go-previous(16x16): /usr/share/icons/bloom/actions/22/go-previous.svg
(process:33512): Helpers.IconFetcher-DEBUG: 18:00:16.267: found icon go-next(16x16): /usr/share/icons/bloom/actions/22/go-next.svg
(process:33512): Helpers.IconFetcher-DEBUG: 18:00:16.363: Query: rofi(192)
(process:33512): Helpers.IconFetcher-DEBUG: 18:00:16.363: starting up icon fetching thread.
(process:33512): Helpers.IconFetcher-DEBUG: 18:00:16.364: found icon rofi(192x192): /home/qball/.local/share/icons/hicolor/scalable/apps/rofi.svg

[rileyophus]

Here is the output of echo -en "test\x00icon\x1fappimage-filen" | G_MESSAGES_DEBUG=Helpers.IconFetcher rofi -dmenu. The icon it should be finding is ~/.local/share/icons/hicolor/1024x1024/apps/appimage-filen.png.

I also discovered it's not just a problem in ~/.local/share/icons, this also happens with /usr/share/icons/HighContrast. /usr/share/icons/HighContrast/256x256/apps/system-file-manager.png for example is also not being found. Here is the output of echo -en "test\x00icon\x1fsystem-file-manager" | G_MESSAGES_DEBUG=Helpers.IconFetcher rofi -dmenu

[DaveDavenport]

@sardemff7 you ideas. Is 1024 a valid size?

Looking at the code, I don't see anything wrong on rofi side. It all depends on how on your system the XDG directories are setup.

I've tested on my system, it picks up icons from hicolor just fine.

(process:61250): Helpers.IconFetcher-DEBUG: 19:48:00.424: Query: io.github.benjamimgois.goverlay(192)
(process:61250): Helpers.IconFetcher-DEBUG: 19:48:00.424: starting up icon fetching thread.
(process:61250): Helpers.IconFetcher-DEBUG: 19:48:00.426: found icon io.github.benjamimgois.goverlay(192x192): /usr/share/icons/hicolor/512x512/apps/io.github.benjamimgois.goverlay.png

[sardemff7]

Here is the output of echo -en "test\x00icon\x1fappimage-filen" | G_MESSAGES_DEBUG=Helpers.IconFetcher rofi -dmenu. The icon it should be finding is ~/.local/share/icons/hicolor/1024x1024/apps/appimage-filen.png.

Does your /usr/share/icons/hicolor/index.theme references the 1024 size? We only walk directories that are defined in the theme, as defined in the spec

I also discovered it's not just a problem in ~/.local/share/icons, this also happens with /usr/share/icons/HighContrast. /usr/share/icons/HighContrast/256x256/apps/system-file-manager.png for example is also not being found. Here is the output of echo -en "test\x00icon\x1fsystem-file-manager" | G_MESSAGES_DEBUG=Helpers.IconFetcher rofi -dmenu

Can you confirm that it fails to find it with this:

echo -en "test\x00icon\x1fsystem-file-manager" | G_MESSAGES_DEBUG=Helpers.IconFetcher rofi -dmenu -show-icons -icon-theme HighContrast

HighContrast is not a fallback theme so there is no reason to search it unless explicitly asked for

[rileyophus]

1024x1024 wasn't in the index.theme, and adding -icon-theme HighContrast made the HighContrast icon show up properly. The problem is, programs can in fact provide 1024x1024 icons as their default and they will reference HighContrast icons as the default as well, so how do I make icons/hicolor/1024x1024 and icons/HighContrast discoverable to Rofi by default?

[DaveDavenport]

I'll add an option to override the fallback themes. (https://github.com/davatorium/rofi/tree/i2326)

The 1024 size not used when not listed in the theme's index file as valid size is not for rofi to resolve.

[mohsenbaheri]

[Icon Theme]
Name=HighContrast
Directories=16x16/apps,32x32/apps,48x48/apps,1024x1024/apps

[1024x1024/apps]
Size=1024
Type=Threshold
Context=Applications