fix(llm, openai, openrouter, llamacpp): Decode tool call argument nulls - #1164
Open
JeanMertz wants to merge 2 commits into
Open
fix(llm, openai, openrouter, llamacpp): Decode tool call argument nulls#1164JeanMertz wants to merge 2 commits into
JeanMertz wants to merge 2 commits into
Conversation
Optional tool arguments encoded as null by strict providers reach tools as omitted fields. This lets Bookworm apply its defaults rather than rejecting `kinds: null`. Explicit values, source-accepted nulls, and required arguments retain their meaning. Pair schema conversion with request-local decoding plans, consumed when streamed arguments become a complete tool call. Cover OpenAI's streaming and non-streaming paths, OpenRouter, and llama.cpp without changing MCP transport or persisted event types. Keep reference resolution and schema composition behavior unchanged. Decoding through references and general unions remains deferred to T-0h28vbn; shared dispatch validation remains tracked by T-063sw1z. Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optional tool arguments encoded as null by strict providers reach tools as omitted fields. This lets Bookworm apply its defaults rather than rejecting
kinds: null. Explicit values, source-accepted nulls, and required arguments retain their meaning.Pair schema conversion with request-local decoding plans, consumed when streamed arguments become a complete tool call. Cover OpenAI's streaming and non-streaming paths, OpenRouter, and llama.cpp without changing MCP transport or persisted event types.
Keep reference resolution and schema composition behavior unchanged. Decoding through references and general unions remains deferred to T-0h28vbn; shared dispatch validation remains tracked by T-063sw1z.