fix(llm, anthropic): Drop sampling parameters models reject - #1214
Merged
Merged
Conversation
JeanMertz
added this pull request to stack #1215
September 30, 2026 10:57
JeanMertz
force-pushed
the
drop-sampling
branch
2 times, most recently
from
September 30, 2026 13:43
6b0ee22 to
d3f72ed
Compare
JeanMertz
force-pushed
the
drop-sampling
branch
2 times, most recently
from
September 30, 2026 22:38
2ad843e to
a807da4
Compare
Every Claude model from 4.7 onwards answers a non-default `temperature`, `top_p` or `top_k` with a 400, so a configured value made every request to Opus 4.7, Opus 5.5, Sonnet 5.5 and their siblings fail. JP now sends these parameters only to models known to accept them (the 4.6 generation and older), and logs a warning for each configured value it drops. The Models API does not report this, so it lives in JP's model override table as a `sampling` flag, surfaced as the `sampling-parameters` model feature. A model missing from the table gets no sampling parameters: a model this binary does not know is almost always newer than it, and every model since 4.7 rejects them. An older model reached through a custom `base_url` loses its `temperature` as a result, with a warning. Signed-off-by: Jean Mertz <git@jeanmertz.com>
JeanMertz
force-pushed
the
drop-sampling
branch
from
October 1, 2026 10:06
a807da4 to
ebe3513
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every Claude model from 4.7 onwards answers a non-default
temperature,top_portop_kwith a 400, so a configured value made every request to Opus 4.7, Opus 5.5, Sonnet 5.5 and their siblings fail. JP now sends these parameters only to models known to accept them (the 4.6 generation and older), and logs a warning for each configured value it drops.The Models API does not report this, so it lives in JP's model override table as a
samplingflag, surfaced as thesampling-parametersmodel feature. A model missing from the table gets no sampling parameters: a model this binary does not know is almost always newer than it, and every model since 4.7 rejects them. An older model reached through a custombase_urlloses itstemperatureas a result, with a warning.