Repository navigation
Test the Azure DevOps templates during package installation - #142
Merged
Merged
Conversation
TestPackageInstallation only installed the four GitHub-based template variants via dotnet new, never the two azdo-* templates added in #85. It also hard-coded the list of short names, so a future variant could be forgotten again. Short names are now read from the rendered template.json files, and the azdo-* templates are installed with --organization/--projectName to exercise their symbol replacement, asserted against the generated Build/Build.cs. This also uncovered a real bug: the Azdo template's "project" symbol produced a --project switch that collides with dotnet new's own built-in --project option (used for template context evaluation), so that parameter could never actually be set. Renamed the symbol to projectName (--projectName) and updated the README and Adopt-StarterKit.ps1 accordingly. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestPackageInstallationonly installed the four GitHub-based template variants viadotnet new; the twoazdo-*templates added in Add Azure DevOps pipeline template #85 were never exercised.template.jsonfiles instead of a hard-coded list, so a future template variant can't be forgotten again.azdo-*templates are now installed with--organization/--projectName, and a new assertion checks the generatedBuild/Build.csto confirm the symbol replacement actually happened.["Normal", "SourceOnly", ...]variant-name arrays into oneTemplateVariantNamesconstant.Bug found by the new test
The Azdo template's
projectsymbol produced a--projectCLI switch, which collides withdotnet new's own built-in--projectoption (used for template context evaluation) — so that parameter could never actually be set from the command line. Renamed the symbol toprojectName(--projectName) in the template, and updated the corresponding examples in the README andAdopt-StarterKit.ps1.Test plan
./build.ps1 TestPackageInstallation --skip ScanPackages— installs and builds all six templates (including both Azdo variants with--organization/--projectName), the two--benchmarksvariants, the Renovate variant, and the existing-library adoption flow../build.ps1 TestTemplateBuild— builds the rendered template folders for all six variants.Fixes #130
🤖 Generated with Claude Code