Skip to content

terraform: Add support for GitHub Attestations in TFLint installation - #1589

Merged
abdurriq merged 7 commits into
devcontainers:mainfrom
wata727:tflint_attestation
Jul 28, 2026
Merged

terraform: Add support for GitHub Attestations in TFLint installation#1589
abdurriq merged 7 commits into
devcontainers:mainfrom
wata727:tflint_attestation

Conversation

@wata727

@wata727 wata727 commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

Fixes #1563

@wata727
wata727 requested a review from a team as a code owner February 23, 2026 07:42

@Kaniska244 Kaniska244 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wata727

Thank you for the contribution. Would you kindly bump the feature version and look into the failing test?

@wata727
wata727 requested a review from Kaniska244 February 28, 2026 08:38
Comment thread test/terraform/scenarios.json Outdated
@wata727
wata727 force-pushed the tflint_attestation branch from b6e506a to a4e7fa6 Compare March 14, 2026 17:09
@wata727
wata727 requested a review from Kaniska244 March 14, 2026 17:17
@nranderson

Copy link
Copy Markdown

@Kaniska244 Would appreciate if this update could be prioritized. It appears the endpoint cosign was using has been removed and our builds are now failing without this update.

[2026-05-26T13:17:25.942Z] 
20.99 Error: searching log query: Post "https://rekor.sigstore.dev/api/v1/log/en
[2026-05-26T13:17:25.942Z] 
ntries/retrieve": POST https://rekor.sigstore.dev/api/v1/log/entries/retrieve giv
ving up after 4 attempt(s): Post "https://rekor.sigstore.dev/api/v1/log/entries/r
[2026-05-26T13:17:25.942Z] 
retrieve": dial tcp 127.232.108.0:443: connect: connection refused
[2026-05-26T13:17:25.942Z] 
20.99 error during command execution: searching log query: Post "https://rekor.s
[2026-05-26T13:17:25.942Z] 
sigstore.dev/api/v1/log/entries/retrieve": POST https://rekor.sigstore.dev/api/v1
1/log/entries/retrieve giving up after 4 attempt(s): Post "https://rekor.sigstore
[2026-05-26T13:17:25.942Z] 
e.dev/api/v1/log/entries/retrieve": dial tcp 127.232.108.0:443: connect: connecti
[2026-05-26T13:17:25.942Z] 
ion refused
[2026-05-26T13:17:25.942Z] 
21.00 ERROR: Feature "Terraform, tflint, and TFGrunt" (ghcr.io/devcontainers/fea
[2026-05-26T13:17:25.942Z] 

@MVJosh

MVJosh commented Jun 8, 2026

Copy link
Copy Markdown

Any chance we can prioritise this for merging please? It looks like the requested changes have been addressed.
#773 is an issue again, making this feature uninstallable - it would be good to remove the dependency on cosign.

In the short term, is there any way to install this feature from this branch? vscode just seems to use the default branch with no obvious way to change it

@NathanCYee

Copy link
Copy Markdown

@Kaniska244 please see if you could review the latest changes. As mentioned by @MVJosh and @nranderson cosign is now removed and builds of the feature are starting to fail at the cosign install step. It would be good to remove the dependency on cosign and align with the gh attestation method used with newer tflint releases

@Clockwork-Muse

Copy link
Copy Markdown
Contributor

Side note: parts of cosign appear to be blocked on some corporate networks, preventing install of terraform/tflint in those networks.

@NathanCYee

Copy link
Copy Markdown

@bamurtaugh could you help find a reviewer for this PR?

@Kaniska244

Copy link
Copy Markdown
Contributor

@Kaniska244 Would appreciate if this update could be prioritized. It appears the endpoint cosign was using has been removed and our builds are now failing without this update.

[2026-05-26T13:17:25.942Z] 
20.99 Error: searching log query: Post "https://rekor.sigstore.dev/api/v1/log/en
[2026-05-26T13:17:25.942Z] 
ntries/retrieve": POST https://rekor.sigstore.dev/api/v1/log/entries/retrieve giv
ving up after 4 attempt(s): Post "https://rekor.sigstore.dev/api/v1/log/entries/r
[2026-05-26T13:17:25.942Z] 
retrieve": dial tcp 127.232.108.0:443: connect: connection refused
[2026-05-26T13:17:25.942Z] 
20.99 error during command execution: searching log query: Post "https://rekor.s
[2026-05-26T13:17:25.942Z] 
sigstore.dev/api/v1/log/entries/retrieve": POST https://rekor.sigstore.dev/api/v1
1/log/entries/retrieve giving up after 4 attempt(s): Post "https://rekor.sigstore
[2026-05-26T13:17:25.942Z] 
e.dev/api/v1/log/entries/retrieve": dial tcp 127.232.108.0:443: connect: connecti
[2026-05-26T13:17:25.942Z] 
ion refused
[2026-05-26T13:17:25.942Z] 
21.00 ERROR: Feature "Terraform, tflint, and TFGrunt" (ghcr.io/devcontainers/fea
[2026-05-26T13:17:25.942Z] 

Hi @nranderson, Hi @MVJosh, Hi @NathanCYee, Hi @wata727

I am so sorry for the delay. I am checking it right now. Will get back ASAP.

@Kaniska244 Kaniska244 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wata727

Would you kindly resolve the conflict. The rest appear to be fine as explained.

@Kaniska244
Kaniska244 requested a review from abdurriq July 24, 2026 06:42
curl -sSL -o /tmp/tf-downloads/${TFLINT_FILENAME} https://github.com/terraform-linters/tflint/releases/download/v${TFLINT_VERSION}/${TFLINT_FILENAME}
}

verify_tflint_attestations() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Would be nice to have this shared across the scripts rather than defined in both places, to avoid potential drift.

@abdurriq
abdurriq dismissed Kaniska244’s stale review July 28, 2026 14:03

Conflict resolved

@abdurriq
abdurriq merged commit 4170bca into devcontainers:main Jul 28, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

features/terraform: Migrate Cosign to GitHub Artifact Attestations for TFLint verification

7 participants