terraform: Add support for GitHub Attestations in TFLint installation - #1589
Conversation
Kaniska244
left a comment
There was a problem hiding this comment.
Hi @wata727
Thank you for the contribution. Would you kindly bump the feature version and look into the failing test?
b6e506a to
a4e7fa6
Compare
|
@Kaniska244 Would appreciate if this update could be prioritized. It appears the endpoint cosign was using has been removed and our builds are now failing without this update. |
|
Any chance we can prioritise this for merging please? It looks like the requested changes have been addressed. In the short term, is there any way to install this feature from this branch? vscode just seems to use the default branch with no obvious way to change it |
|
@Kaniska244 please see if you could review the latest changes. As mentioned by @MVJosh and @nranderson cosign is now removed and builds of the feature are starting to fail at the cosign install step. It would be good to remove the dependency on cosign and align with the gh attestation method used with newer tflint releases |
|
Side note: parts of cosign appear to be blocked on some corporate networks, preventing install of terraform/tflint in those networks. |
|
@bamurtaugh could you help find a reviewer for this PR? |
Hi @nranderson, Hi @MVJosh, Hi @NathanCYee, Hi @wata727 I am so sorry for the delay. I am checking it right now. Will get back ASAP. |
Kaniska244
left a comment
There was a problem hiding this comment.
Hi @wata727
Would you kindly resolve the conflict. The rest appear to be fine as explained.
| curl -sSL -o /tmp/tf-downloads/${TFLINT_FILENAME} https://github.com/terraform-linters/tflint/releases/download/v${TFLINT_VERSION}/${TFLINT_FILENAME} | ||
| } | ||
|
|
||
| verify_tflint_attestations() { |
There was a problem hiding this comment.
Nit: Would be nice to have this shared across the scripts rather than defined in both places, to avoid potential drift.
Fixes #1563