ci: split the Windows test job into unit and integration legs - #1938
Merged
Merged
Conversation
Windows was the slowest Test leg at 5.8 min, 3.2 of it running the test binaries one after another (lib 80s, xlsx 65s, pptx 34s). Its unit and doctest targets and its integration targets now run as parallel legs; the quoted --test '*' wildcard picks up integration targets added later. Linux and macOS keep one leg, which also builds examples. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File submission policy
Before attaching or committing files, read the submission policy.
Summary
First of three follow-ups from a CI review with Codex. The current warm PR run takes 6.1 min. In that run (36325703306), Test (windows-latest) took 5.8 min: 1m34s to build, then ~3.2 min running test binaries one after another. The lib unit tests took 79.7s,
xlsx_fixtures64.8s andpptx_fixtures33.6s.Windows now runs as two parallel legs:
unitscargo test --workspace --profile ci --lib --bins, then--docintegrationcargo test --workspace --profile ci --test '*'cargo metadataconfirms the partition covers every test target exactly once: 3 libraries plus the CLI binary, the 3 libraries' doctests, and 12 integration targets.cargo testalso builds examples, so they stay covered there (none exist today).test-ci-profileentry, so no cache budget is added.Expected: slower Windows leg ~4-4.5 min (not yet measured; this PR's run shows it).
Related issue
Related: #1908
Testing
python3 -m unittest scripts.tests.test_dependency_lock_contract(5/5)Visual impact
🤖 Generated with Claude Code