You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
upstream: MSVC header/library subsets as source directories in windows_support and hermetic-llvm (follow-up to #8912) #9081
Part of #8912. Follow-up to the windows_x86_64 slice on branch ci-win-x64-8912-3, which moves the MSVC header and library subsets from copy_to_directory build actions into the @msvc_runtime repository layout. It does this with two override patches (patches/windows_support/dx_msvc_layout.patch and a new patches/llvm/msvc_source_directories.patch). This issue covers sending both changes upstream so the patches can be dropped later.
Where
Upstream windows_support (windows/private/extensions/msvc_runtime.bzl and msvc_runtime.BUILD.bazel), and hermeticbuild/hermetic-llvm runtimes/msvc/BUILD.bazel.
Local copies: patches/windows_support/dx_msvc_layout.patch, patches/llvm/msvc_source_directories.patch, patches/README.md, cli/adopt/src/overrides.rs, cli/adopt/BUILD.bazel, MODULE.bazel, and families/*/third_party/rules_dx/.
Fix
After the slice merges, open a windows_support PR that adds the subset directories and the directory/subdirectory targets. Then open a hermetic-llvm PR that uses them in place of the six copy_to_directory targets. Link both PRs in patches/README.md.
Once both releases are out, bump the bazel_dep versions, delete the hunks and the new llvm patch from every file listed under Where, and run bazel mod deps --lockfile_mode=update (root and families).
Blocked upstream. Dropping our patches needs:
(a) a windows_support release that includes hermeticbuild/windows_support#21 (latest is v0.4.1, without it), and
(b) a hermetic-llvm release that includes hermeticbuild/hermetic-llvm#920 (draft; we pin 0.8.26).
#920 currently fails e2e/cross_compilation last_rc on @@windows_support++msvc_runtime+msvc_runtime//:msvc_com_support_include, which exists only after #21 is released. Once both releases ship, one PR bumps both in MODULE.bazel, drops patches/llvm/msvc_source_directories.patch and the subset hunks of dx_msvc_layout.patch (together with the source_directory_headers drop, #9135), and refreshes the lockfiles.
This issue has the blocked label but no Blocked on: line in its body. Add one naming the blocking issue (#N), a pull request URL, or the owner action. See CONTRIBUTING.md.
Activity
TrapsterDK commentedon Nov 7, 2026
Upstream: hermeticbuild/windows_support#20 and PR #21; hermeticbuild/hermetic-llvm#919 and PR #920.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Xut2hzpb4qWNZKpDCrwUz7
patches: link the upstream windows_support and hermetic-llvm MSVC sub…
patches: link the upstream windows_support and hermetic-llvm MSVC sub…
TrapsterDK commentedon Nov 7, 2026
Blocked upstream. Dropping our patches needs:
(a) a windows_support release that includes hermeticbuild/windows_support#21 (latest is v0.4.1, without it), and
(b) a hermetic-llvm release that includes hermeticbuild/hermetic-llvm#920 (draft; we pin 0.8.26).
#920 currently fails e2e/cross_compilation last_rc on
@@windows_support++msvc_runtime+msvc_runtime//:msvc_com_support_include, which exists only after #21 is released. Once both releases ship, one PR bumps both in MODULE.bazel, dropspatches/llvm/msvc_source_directories.patchand the subset hunks ofdx_msvc_layout.patch(together with the source_directory_headers drop, #9135), and refreshes the lockfiles.🤖 Generated with Claude Code
github-actions commentedon Nov 7, 2026
This issue has the
blockedlabel but noBlocked on:line in its body. Add one naming the blocking issue (#N), a pull request URL, or the owner action. See CONTRIBUTING.md.