Skip to content

hermetic: Windows evidence has an empty host kernel, so Verify rejects it #9314

Closed

Description

@TrapsterDK

hermetic-windows "Verify the evidence" rejects otherwise qualified MSVC evidence: hermetic evidence rejected: evidence names no host kernel (ci.yml run 42375312749, windows_x86_64 job 128411581848). The evidence has "host": {"os": "windows", "kernel": ""}.

Where

  • tools/testing/hermetic/src/lib.rs host(): reads /proc/sys/kernel/osrelease, then falls back to uname -r. Windows has neither, so kernel is empty.
  • The verifier loop over ["os", "arch", "kernel"] in the same file then rejects it.
  • host_names_this_machine in src/tests.rs is #[cfg(unix)], so Windows is never checked.

Fix

  • On Windows, fill kernel with the OS build, for example the [Version 10.0.x.y] from %SystemRoot%\System32\cmd.exe /c ver. Use an absolute path, because the test PATH is stripped.
  • Drop #[cfg(unix)] from host_names_this_machine.
  • Proof: in a hermetic-windows ci.yml run, the Verify step is green on both arches.

Found while closing #4825.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Xut2hzpb4qWNZKpDCrwUz7

Activity

  1. added
    P2Improve and finish existing features
    model:sonnetAgent lane: scoped change with stated design, Sonnet
    on Nov 7, 2026
  2. TrapsterDK commented on Nov 7, 2026

    @TrapsterDK
    CollaboratorAuthor

    Evidence run 42378305957 (windows_x86_64, hermetic_unit_test) passed. PR #9316 is ready.

    🤖 Generated with Claude Code

    https://claude.ai/code/session_01Xut2hzpb4qWNZKpDCrwUz7

  3. added a commit that references this issue on Nov 7, 2026
    b931d61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Improve and finish existing featuresmodel:sonnetAgent lane: scoped change with stated design, Sonnet

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions