Skip to content

deploy: native_probe uses py_extension on Windows now that rules_python is patched #9318

Closed

Description

@TrapsterDK

Part of #7119.

Where

  • deploy/rules/native_probe/dx_native_probe/BUILD.bazel:19: _core_windows_impl / _core_windows_dll link the module by hand because py_extension passed both CPython import libraries in one linker argument.

Fix

  1. patches/rules_python/single_import_lib.patch fixes that, so use the same py_extension target on Windows as on Linux and delete the Windows-only cc_library/cc_shared_library pair and its comment.
  2. Tests: tools/dx test //deploy/rules/native_probe/... on Linux, plus /evidence platforms=["windows_x86_64","windows_arm64"] task=test scope=//deploy/rules/native_probe/....

Activity

  1. added
    P2Improve and finish existing features
    model:sonnetAgent lane: scoped change with stated design, Sonnet
    on Nov 7, 2026
  2. TrapsterDK commented on Nov 7, 2026

    @TrapsterDK
    CollaboratorAuthor

    PR 9345 ready. Windows evidence runs 42383633038, 42383744677, 42383860727 failed on the local_config_winsdk @rules_dx visibility error (unrelated). Windows build of py_extension _core still unverified.

  3. added a commit that references this issue on Nov 7, 2026
    681c1fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Improve and finish existing featuresmodel:sonnetAgent lane: scoped change with stated design, Sonnet

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions