Repository navigation
refactor(adopt): delete test-only API and trim the dx_adopt facade (#2443) - #3885
Conversation
…2443) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK
…facade comment (#2443) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK
242758c to
88957aa
Compare
Coverage summary — coverage linux_x86_64 — FAILAnalyzed revision: Gate exit: 1 (comment never changes this outcome). Changed-line gate exit: not configured LCOV: Bazel-owned combined report for this cell (see workflow run 40465059020). Scope: per-cell exact counts only; no cross-cell union, no averaged percentages, no rounding up. Codecov stays opt-in only, never required. Findings outside the diff stay in counts only; no invented review locations. |
Coverage summary — coverage macos_arm64 — FAILAnalyzed revision: Gate exit: 1 (comment never changes this outcome). Changed-line gate exit: not configured LCOV: Bazel-owned combined report for this cell (see workflow run 40465059020). Scope: per-cell exact counts only; no cross-cell union, no averaged percentages, no rounding up. Codecov stays opt-in only, never required. Findings outside the diff stay in counts only; no invented review locations. |
Closes #2443.
Removes production API in
cli/adoptthat only tests used, and cuts thedx_adoptfacade down to the names other crates import. Users see no change in behavior.Deleted
policy.rs(devcontainer_is_admissible,diagnostics_command_allowed)render_consumer_own_toolchain_setup,render_consumer_renamed_setup,editor_disposition,editor_language_supportedPREVIOUS_VERSION,rollback_re_pins_previousmigrate_is_major_bumpis_truthy,shares_file_with_other_tablesrender_status_json,StatusPayload,SerializeonStatusCheck. Status JSON still comes from cli/cli events.watch_for_change*_reexports_match_local_definitionstestsMoved
ConsumerSetupandparse_consumer_setupnow live in#[cfg(test)] pub(crate) mod version::consumer_setup.Facade
lib.rspub usenow lists exactly the 54 names that cli/cli, cli/update and cli/advisory_prep import. Code inside the crate usescrate::<module>::paths.Other changes
ConfigFile.dependency_setis renamed to_dependency_setwith#[serde(rename = "dependency_set")]. The field has no reader any more, and this avoids a dead_code warning without adding#[allow]. It still parses[[dependency_set]]and still rejects values that are not arrays. A new test pins that:new_files_reject_a_non_array_dependency_set.migrate_syntax_pins_semver_prerelease_and_errorsnow checksmigrate_is_upgradefor prerelease, build-metadata and non-semver cases.WatchSessiondirectly (session_reports_created_files_and_times_out_when_idle).src/policy.rsand//cli/fingerprint:dx_fingerprint. Gazelle keptinsta. Cargo.toml and the lockfile are unchanged.devcontainer_is_admissible.Verification
tools/dx fix --affected: lint and typecheck report 0 warnings over the affected set, which includes//:dxand//cli/cli:dx_cli. Format flaggedcli/cli/src/exec/{test_support,umbrella}.rs. Those files were already unformatted on main and this PR does not touch them.bazel test //cli/adopt/... //cli/update/... //cli/advisory_prep/... //quality:clippy_policy_test //tools/ci:release_assets_test: 12 of 12 pass.Follow-ups
instafromcli/adopt/Cargo.tomland repin.super::facade references at module paths.🤖 Generated with Claude Code
https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK