Repository navigation
release: fill pins.bzl into the release source archive - #6418
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6166
The
sourcejob now needscells, builds the checksum manifest, fills a copy ofpins.bzlwithfill_pins_bin --manifest, and builds the archive withsource_archive --pins. The manifest, sidecars and raw binaries travel in thesourceartifact;uploadonly checks them. Thepinsjob checks the archive's pins with--filled. RELEASING.md drops the fill-pins step.Tests:
//tools/ci:release_assets_test25 pass, 6 fail; the 6 failed the same way before (stale launcher/upload-loop assertions, pins at 0.0.0), not touched.dx checklint failed at the lint phase; not investigated. Not run: the fork release run (owner proof).Assisted by Claude.
🤖 Generated with Claude Code
https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK