Repository navigation
launcher: sweep temp files of dead pids before copying dx (part of #6207) - #6419
Merged
Merged
Conversation
A run SIGKILLed during the copy skips its trap, so dx.<pid>, built.<pid> and inputs.<pid> stayed in .dx/launcher for good. sync_copy now removes those whose pid no longer answers kill -0. The launcher test covers a dead and a live pid. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK
TrapsterDK
force-pushed
the
fix-6207-launcher-temp-leak
branch
from
November 4, 2026 20:32
af4f24a to
0812e9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #6207
A
tools/dxrun that is SIGKILLed skips its trap, sodx.<pid>,built.<pid>andinputs.<pid>stay in.dx/launcherfor good.Change
tools/dx:sync_copyfirst removesdx.N,built.Nandinputs.Nwhose pid no longer answerskill -0. Live runs, including the current one, are kept.tools/dx_launcher_test.sh: before the launcher runs, createsdx.999999andbuilt.999999(dead pid) anddx.$$(live pid). Asserts the dead ones are gone and the live one stays.Remaining
tools/dx.cmdhas the same leak (built.<guid>,query.<guid>). Its tags are GUIDs, not pids, so the liveness check needs a different tag scheme. Not done here. Windows only.Testing
tools/dx: the new test fails on the old launcher (the launcher kept dx.999999 from a dead pid) and passes on the new one.tools/dx test //tools:dx_launcher_test: passed.tools/dx check --apply //tools:all: failed in the generate phase on unrelated fixtures undertools/docs(Pester,mylib, vue fixtures). Format, lint and typecheck were skipped. shellcheck was not run.*_consumer_testtargets (CI runs them).🤖 Generated with Claude Code
Assisted by Claude.