Repository navigation
adopt: read release pins from dx-sha256sums.txt next to dx (part of #6167) - #6422
Merged
Merged
Conversation
…mbedded (part of #6167) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #6167.
When the embedded pins are empty,
release_pinsnow readsdx-sha256sums.txtfrom the directory of the running executable. A bad manifest errors with a message saying.dx/versionwould be written without hashes; a missing one keeps the unpinned behaviour. Test:manifest_dir_gives_pins_and_missing_manifest_gives_none.Remaining:
Tests:
//cli/adopt:dx_adopt_testpasses exceptoverrides::tests::table_matches_the_repo_module_bazel(gcc_toolchain patches, untouched here). No consumer tests run.Assisted by Claude.
🤖 Generated with Claude Code
https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK