Repository navigation
worktree: rc_output_roots reads quoted paths with spaces (closes #6208) - #6425
Merged
Merged
Conversation
rc_output_roots split rc lines on whitespace, so a quoted --output_user_root path with spaces was cut at the first space and the real root was never reclaimed. Use the quote-aware rc tokenizer from dx_process, make it public, and accept the separate-value form of --output_user_root too. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK
TrapsterDK
force-pushed
the
fix-6208-rc-quoted-output-root
branch
from
November 4, 2026 20:30
add6c1b to
e12dde8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6208
rc_output_rootssplit.bazelrclines on whitespace, sostartup --output_user_root="/home/u/my cache"yielded/home/u/myand the real root was never reclaimed. Now it uses the quote-aware rc tokenizer fromdx_process(madepub), forstartuplines, the separate-value form--output_user_root "/path", andimport/try-importpaths. The#comment cutoff is kept.Tests:
tools/dx check --apply //cli/worktree/... //cli/process/...: exit 0, no changes applied.tools/dx test //cli/worktree:dx_worktree_test //cli/process:dx_process_test: 2 of 2 pass. New testrc_output_roots_keep_quoted_paths_with_spacesis next torc_output_roots_read_startup_lines_and_imports.Not run: nested-Bazel and
*_consumer_testtargets (CI runs them). Windows and macOS were not built or run; the new test uses unix absolute paths, as the existing test does.Base: branched from origin/main at f394118. Main has since moved 5 commits (including #6368 touching
cli/process/src/rc.rs, a different hunk). Not rebased here; the merge lane rebases.🤖 Generated with Claude Code
Assisted by Claude.