Repository navigation
dx build/test: summary line for skipped incompatible targets (part of #6175) - #6426
Merged
Merged
Conversation
…atible (part of #6175) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #6175.
First slice: dx now reads the SKIPPED
targetCompletedevents and prints one line, for bothdx buildanddx test:dx: skipped N targets incompatible with this platform (docs/support-matrix.md). In JSON mode it is atargets_skippedinfo notice. Exit code is unchanged. New modulecli/cli/src/exec/skipped_targets.rs.Remaining from the plan: per-language
unsupportedconstraint incells.bzland the wrappers,unsupported.jsonfrom the support matrix facts with the reasons and drift check, per-language lines with reasons, the reason inbuild_failures.rsfor explicitly requested incompatible targets, and the Starlark/facts/wrapper tests.Tests: new unit tests in skipped_targets.rs and one text-mode test in test_reports.rs pass. Two unrelated coverage tests (
coverage_*_tracefile_skipped*) fail in this sandbox (not a Git work tree). Nested-Bazel/consumer tests not run.Assisted by Claude.
🤖 Generated with Claude Code
https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK