Repository navigation
plan/changed: read backslash local_path_override paths (closes #6212) - #6430
Merged
Merged
Conversation
On Windows, MODULE.bazel can say path = "..\\lib". The override filter split only on '/', so the outside-repo override was dropped and an affected-scoped run selected nothing that depends on it. Normalize backslashes to '/' before the '..' filter and the repo-relative resolution. Absolute paths are still skipped on the original string. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6212
local_override_changessplit override paths on/only. AMODULE.bazelon Windows withpath = "..\\lib"was dropped by the..filter, so an affected-scoped run selected nothing that depends on that override.The fix normalizes
\to/on each override path before the..filter and the repo-relative resolution. ThePath::is_absolutecheck still runs on the original string.Added
override_changes_read_backslash_override_paths_like_slash_paths, which asserts the same roots, pathspecs and changed files as../lib.Checks:
tools/dx check --apply //cli/plan/...: passed. This also reformatted unrelated files, which I reverted, so the diff is onlycli/plan/src/resolve/changed.rs.tools/dx test //cli/plan:dx_plan_test: 1 of 1 passed.Not run:
*_consumer_testtargets were not run locally (CI runs them)...\liboverride has not been exercised.Assisted by Claude.
🤖 Generated with Claude Code